Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Input] Does not have a color prop #11644

Closed
2 tasks done
LiamEderzeel opened this issue May 30, 2018 · 2 comments
Closed
2 tasks done

[Input] Does not have a color prop #11644

LiamEderzeel opened this issue May 30, 2018 · 2 comments
Labels
component: text field This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@LiamEderzeel
Copy link

LiamEderzeel commented May 30, 2018

  • This is a v1.x issue (v0.x is no longer maintained).
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

The expectation is that this components colors can be modified thought a color prop like similar form components, such as Button and Checkbox.

Current Behavior

Currently you have to overwrite the styles through the classes prop to achieve the desired result.

Context

I use a primary and a secondary color theme in the jss theme for the project I'm currently working on. The primary color pallet are the brand colors and the secondary color pallet is used for highlighting what parts of the site are intractable like buttons menus forms.

Your Environment

Tech Version
Material-UI v1.0.0
React v16.4.0
browser chrome (latest)
etc
@oliviertassinari oliviertassinari changed the title [Select] Does not have a color prop [Input] Does not have a color prop May 30, 2018
@oliviertassinari oliviertassinari added new feature New feature or request component: text field This is the name of the generic UI component, not the React module! labels May 30, 2018
@oliviertassinari
Copy link
Member

@LiamEderzeel The Select component is built on top of the input. You can use the same customization options (theme or CSS) https://material-ui.com/demos/text-fields/#customized-inputs.

I use a primary and a secondary color theme in the jss theme for the project I'm currently working on.

This use case sounds good to me. Let's move #10745 discussion here.

@oliviertassinari
Copy link
Member

Since #17891 and thanks to @ValentinH, we now have a color prop on the TextField, Input, FilledInput and OutlinedInput components. It supports primary and secondary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: text field This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants