Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo menu with fade transition doesn't remove the transparent backdrop #11718

Closed
01e9 opened this issue Jun 5, 2018 · 3 comments
Closed

Demo menu with fade transition doesn't remove the transparent backdrop #11718

01e9 opened this issue Jun 5, 2018 · 3 comments
Assignees
Labels
bug 🐛 Something doesn't work

Comments

@01e9
Copy link

01e9 commented Jun 5, 2018

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jun 5, 2018
@oliviertassinari oliviertassinari self-assigned this Jun 5, 2018
@DominikSerafin
Copy link
Contributor

Experiencing this bug myself

It happens when only transition component is supplied (TransitionComponent={Fade})

I've found workaround, which is basically declaring additional explicit transition timeout (TransitionProps={{timeout: 400}})

So my final element looks like this:

  <Popover
    ...
    TransitionComponent={Fade}
    TransitionProps={{timeout: 400}}
  >

Here's the stack trace of the error before the workaround:

warning.js?dfb8:33
Warning: Failed prop type: Invalid prop `timeout` supplied to `Fade`.
    in Fade (created by WithTheme(Fade))
    in WithTheme(Fade) (created by Popover)
    in RootRef (created by Modal)
    in div (created by Modal)
    in Portal (created by Modal)
    in Modal (created by WithStyles(Modal))
    in WithStyles(Modal) (created by Popover)
    in Popover (created by WithStyles(Popover))
    in WithStyles(Popover) (created by TopBar)
    in div (created by TopBar)
    in div (created by TopBar)
    in div (created by TopBar)
    in TopBar (created by Connect(Component))
    in Connect(Component) (created by Route)
    in Route (created by withRouter(Connect(Component)))
    in withRouter(Connect(Component)) (created by App)
    in div (created by App)
    in MuiThemeProvider (created by App)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by App)
    in App (created by Connect(AppComponent))
    in Connect(AppComponent)
    in Provider
printWarning @ warning.js?dfb8:33
warning @ warning.js?dfb8:57
checkPropTypes @ checkPropTypes.js?12cb:52
validatePropTypes @ react.development.js?99ee:1233
createElementWithValidation @ react.development.js?99ee:1321
render @ withTheme.js?303b:84
finishClassComponent @ react-dom.development.js?cada:8389
updateClassComponent @ react-dom.development.js?cada:8357
beginWork @ react-dom.development.js?cada:8982
performUnitOfWork @ react-dom.development.js?cada:11814
workLoop @ react-dom.development.js?cada:11843
renderRoot @ react-dom.development.js?cada:11874
performWorkOnRoot @ react-dom.development.js?cada:12449
performWork @ react-dom.development.js?cada:12370
performSyncWork @ react-dom.development.js?cada:12347
interactiveUpdates @ react-dom.development.js?cada:12597
interactiveUpdates @ react-dom.development.js?cada:1958
dispatchInteractiveEvent @ react-dom.development.js?cada:4259

warning.js?dfb8:33
Warning: Failed prop type: Invalid prop `timeout` supplied to `Transition`.
    in Transition (created by Fade)
    in Fade (created by WithTheme(Fade))
    in WithTheme(Fade) (created by Popover)
    in RootRef (created by Modal)
    in div (created by Modal)
    in Portal (created by Modal)
    in Modal (created by WithStyles(Modal))
    in WithStyles(Modal) (created by Popover)
    in Popover (created by WithStyles(Popover))
    in WithStyles(Popover) (created by TopBar)
    in div (created by TopBar)
    in div (created by TopBar)
    in div (created by TopBar)
    in TopBar (created by Connect(Component))
    in Connect(Component) (created by Route)
    in Route (created by withRouter(Connect(Component)))
    in withRouter(Connect(Component)) (created by App)
    in div (created by App)
    in MuiThemeProvider (created by App)
    in Router (created by BrowserRouter)
    in BrowserRouter (created by App)
    in App (created by Connect(AppComponent))
    in Connect(AppComponent)
    in Provider
printWarning @ warning.js?dfb8:33
warning @ warning.js?dfb8:57
checkPropTypes @ checkPropTypes.js?12cb:52
validatePropTypes @ react.development.js?99ee:1233
createElementWithValidation @ react.development.js?99ee:1321
render @ Fade.js?dec3:104
finishClassComponent @ react-dom.development.js?cada:8389
updateClassComponent @ react-dom.development.js?cada:8357
beginWork @ react-dom.development.js?cada:8982
performUnitOfWork @ react-dom.development.js?cada:11814
workLoop @ react-dom.development.js?cada:11843
renderRoot @ react-dom.development.js?cada:11874
performWorkOnRoot @ react-dom.development.js?cada:12449
performWork @ react-dom.development.js?cada:12370
performSyncWork @ react-dom.development.js?cada:12347
interactiveUpdates @ react-dom.development.js?cada:12597
interactiveUpdates @ react-dom.development.js?cada:1958
dispatchInteractiveEvent @ react-dom.development.js?cada:4259

@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 5, 2018

It a regression introduced by #11657.

@oliviertassinari
Copy link
Member

@arteniioleg @DominikSerafin Thanks for raising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

No branches or pull requests

3 participants