Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollable dialog - Proposal #11950

Closed
adostal opened this issue Jun 22, 2018 · 1 comment
Closed

Scrollable dialog - Proposal #11950

adostal opened this issue Jun 22, 2018 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@adostal
Copy link

adostal commented Jun 22, 2018

Hi,
we often use big dialogs. In this case is problem that dialog haven't scrollable version.

Can you implement any scrollable version? My proposal is:

import * as React from 'react';
import {Dialog, withStyles} from '@material-ui/core';
import {DialogProps} from '@material-ui/core/Dialog';

const decorate = withStyles(() => ({
    root: {
        'overflow-y': 'scroll',
        'overflow-x': 'hidden',
        display: 'flex',
    },

    paper: {
        overflow: 'hidden',
        margin: 'auto',
        maxHeight: 'none',
    },
}));

export const ScrollableDialog = decorate<DialogProps>((props) => <Dialog {...props} />);
@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Jun 22, 2018
@oliviertassinari
Copy link
Member

@adostal I believe it's a duplicate of #7438. Yes, we definitely need such feature! I would love to see it come to life. Could you post your solution on the related issue? Maybe even consider doing a pull-requests? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants