Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module ''popper.js'' has no exported member 'ReferenceObject'. #12252

Closed
2 tasks done
Tuaniwan opened this issue Jul 23, 2018 · 6 comments
Closed
2 tasks done

Module ''popper.js'' has no exported member 'ReferenceObject'. #12252

Tuaniwan opened this issue Jul 23, 2018 · 6 comments
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. typescript

Comments

@Tuaniwan
Copy link
Contributor

Tuaniwan commented Jul 23, 2018

  • This is a v1.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

After updating from MUI v1.4.0 to v1.4.1, I get this error when building my project:

 [exec]
 [exec] ERROR in [at-loader] ./node_modules/@material-ui/core/Popper/Popper.d.ts:2:10
 [exec]     TS2305: Module ''popper.js'' has no exported member 'ReferenceObject'.
 [exec]
 [exec] ERROR in [at-loader] ./node_modules/react-popper/typings/react-popper.d.ts:29:23
 [exec]     TS2694: Namespace ''popper.js'' has no exported member 'Placement'.
 [exec]
 [exec] ERROR in [at-loader] ./node_modules/react-popper/typings/react-popper.d.ts:39:24
 [exec]     TS2694: Namespace ''popper.js'' has no exported member 'Modifiers'.
 [exec]
 [exec] ERROR in [at-loader] ./node_modules/react-popper/typings/react-popper.d.ts:40:24
 [exec]     TS2694: Namespace ''popper.js'' has no exported member 'Placement'.
 [exec]
 [exec] ERROR in [at-loader] ./node_modules/react-popper/typings/react-popper.d.ts:42:31
 [exec]     TS2694: Namespace ''popper.js'' has no exported member 'ReferenceObject'.

I checked and popper.js actually doesn't have those. Although, I'm not sure if they have to be explicitly available in popper.js.

Since I am not too familiar with this, I'm not sure if I made an obvious mistake or not. I tested going back to 1.4.0, and it works fine. I checked and there were a few changes to Popper.js in v1.4.1, but nothing that required changes on my part, so I wasn't sure if I had to change anything, but I didn't, except for the MUI version itself.

In case it's relevant and potentially the cause of my problem, my project has those two dependencies:
"popper.js": "1.12.9",
"react-popper": "1.0.0",

Environment

Tech Version
Material-UI v1.4.1
React v16.3.0
browser Chrome
@oliviertassinari
Copy link
Member

@Tuaniwan What version of popper.js have you installed in your node_modules?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 23, 2018

Oh ok. We need to increase the popper.js dependency, we can't use [email protected].
https://github.com/mui-org/material-ui/blob/4eb6628e5be27a6c140c774069ea794d091c48c3/packages/material-ui/package.json#L57

ReferenceObject export was added in [email protected] if I'm not mistaken.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. labels Jul 23, 2018
@Tuaniwan
Copy link
Contributor Author

Tuaniwan commented Jul 23, 2018

@oliviertassinari If ReferenceObject export was added in [email protected], do you mean we can't use the specific version [email protected] only or anything after that too?

@oliviertassinari
Copy link
Member

You can, but the package will be duplicated in your bundle.

@oliviertassinari
Copy link
Member

@Tuaniwan Do you want to increase the minimal required version of popper.js on our package.json?

@Tuaniwan
Copy link
Contributor Author

Tuaniwan commented Jul 23, 2018

Sure, as soon as I am off of work, [email protected] as minimal required version sounds good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work good first issue Great for first contributions. Enable to learn the contribution process. typescript
Projects
None yet
Development

No branches or pull requests

2 participants