Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUI website doesn't work in some cases after update, static caching is broken #13820

Closed
2 tasks done
dmythro opened this issue Dec 5, 2018 · 20 comments
Closed
2 tasks done
Assignees
Labels
docs Improvements or additions to the documentation priority: important This change can make a difference

Comments

@dmythro
Copy link

dmythro commented Dec 5, 2018

The https://material-ui.com/ doesn't work for me pretty often and that happens after static re-generation, most probably a problem with service workers. Right now I have the same issue, index page opens, but the rest doesn't work (even side menu etc).

I had this open in a tab for a while now, seen the snackbar with "3.5.1 is out" or something.
Must say, this kind of caching doesn't really fit the purpose of the website — documentation should not be cached for so long, especially with often releases.

Here's a console output of my Chrome (I use latest versions of Chrome and macOS):
image

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

Website works :)

Current Behavior 😯

Website opens the landing page but the rest is not working. Happens often after releases, Next caching is pretty unstable.
Several months ago even a home page didn't open sometimes.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 6, 2018

@Z-AX Thank you for the feedback. Service workers have been a hell to play with over the last few months. This issue is linked to #13422. What version does it display on the left top corner?

Service workers enable very fast documentation navigation experience.

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation priority: important This change can make a difference labels Dec 6, 2018
@KaRkY
Copy link
Contributor

KaRkY commented Dec 7, 2018

For me when a new release comes out I must always go in console and clear application data. For version 3.5.0 I think I was getting the old release docs for like a week or more.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 7, 2018

@KaRkY Is the site broken or does it that the site doesn't want to update? The thing with documentation are that people often have a dozen pages open. For the next version of the service worker to activate, it has to be a single tab open.

@dmythro
Copy link
Author

dmythro commented Dec 7, 2018

@Z-AX Thank you for the feedback. Service workers have been a hell to play with over the last few months. This issue is linked to #13422. What version does it display on the left top corner?

Thanks. I don't see any version on the top left because menu doesn't open. But in footer there is Currently v3.5.1.

Service workers enable very fast documentation navigation experience.

Exactly. Seen the struggle with new CRA v2+ too.

I cleared all caches and still couldn't make it work (Chrome for macOS, Version 70.0.3538.110 (Official Build) (64-bit).
But just now there was update, to 71.0.3578.80, and it's now up to date with v3.6.1. But it was the complete relaunch of a browser etc.

@cnasikas
Copy link

cnasikas commented Dec 7, 2018

I had a similar problem. The side menu is not working in Firefox (version 63.0.3) but is working in Chrome. I cannot navigate to any page except the links (pages) inside the already open category Get started. Also the pages inside Get started category are reloading and not loading with AJAX as in Chrome

@stevez86
Copy link

stevez86 commented Dec 7, 2018

This has been happening to me for the past few days - the website is unusable (all clicks fail) and the Search bar in the header disappears.

I can get around the issue by opening dev tools, disabling cache and doing a hard refresh. Unregistering / updating service also temporarily gets around the issue but I can't find how to permanently resolve or clear the old version (which I assume is the problem).

It also happened to me about a month ago and was fine until recently. I obviously use the docs alot :)

I can't get to the version in the toolbar because I can't open the drawer. Any other way to get to the version without clicking anything?

@joshwooding
Copy link
Member

It's currently broken on IOS Safari for me probably for the same reason, I can't open the drawer to check the version but it happens every time the docs update, right now I just use IOS Firefox to get around the issue

@KaRkY
Copy link
Contributor

KaRkY commented Dec 7, 2018

@oliviertassinari No the site works OK as far as I saw. It just does not update to new version. If you tell me what you need I can try to debug it. My home browser is stuck on 3.6.0 right now.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 7, 2018

@KaRkY This is a kind of issue that shouldn't be too hard to fix. We can force the installed service worker activation.

My concern is more with the caching strategy https://github.com/GoogleChrome/workbox has. We have been using this library so far hoping they would make the SW usage really simple. We need to do something, I have heard way to many feedback like this one.

@KaRkY
Copy link
Contributor

KaRkY commented Dec 7, 2018

@oliviertassinari The funny thing is I can see 2 caches in chrome dev tools under application tab.
First one is from today when I tried the site and second one is from 27.11.

@dmythro
Copy link
Author

dmythro commented Dec 12, 2018

I just got again old SW cache from v3.5.1 or something, even after I cleared all cache in dev tools Application section, including service workers. So, SW work pretty "amazingly".

@oliviertassinari
Copy link
Member

I think that it's important that we solve this issue. The best path I can think of is to force the service worker activation as soon as it's installed. Any other idea?

@dmythro
Copy link
Author

dmythro commented Dec 18, 2018

Well, for our recent app (which uses CRA v2 and MUI v3) we've decided to not use SW until CRA will fix issues like facebook/create-react-app/issues/5316. But project is in beta still, can afford a bit of waiting. I hope I'll have time to work on this somewhere soon, for the new project as well.

For us it's much more important that users use the most recent version. For MUI docs there is probably the same priority, but probably a higher load.

@oscl
Copy link

oscl commented Dec 20, 2018

You have closed this issue but the actual issue at https://material-ui.com/ website is not yet fixed...

Top left sidenav drawer button is not working

screenshot 38

@dmythro
Copy link
Author

dmythro commented Dec 21, 2018

@AJ-Creations, the issue is still open and unresolved, it's just yours was merged to this one.

@oliviertassinari
Copy link
Member

I'm looking into the problem. It's a sensitive topic for the project. Ironically, we have had this issue since we upgraded from an alpha version of workbox to a stable.

The more I use open source software, the less I find any meaningful core value in the version it's using, the more I see it as pure marketing, which is still important.

@oliviertassinari
Copy link
Member

We gonna release #13987 and see how that goes. I would expect it to solve 80% of the problem.

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 22, 2018

The change was released v3.7.1. Let's see how that goes with the next release after, moving from v3.7.1 to v3.8.0.

@dmythro
Copy link
Author

dmythro commented Dec 31, 2018

Checked site after v3.8.1 update (since v3.7.x), works as expected with up-to-date docs.

@joshwooding
Copy link
Member

@Z-AX I experienced the same 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation priority: important This change can make a difference
Projects
None yet
Development

No branches or pull requests

7 participants