[Dialog] Discrepancy between documentation and reality

[bitfede]

Found some nonsense that needs to be fixed:

On the official Material UI documentation it says we can use all the values from 'xs' to 'xl' . [ link: https://material-ui.com/demos/dialogs/ ]

but when I pass the prop 'xl' I get this error in my console:

There's a guy in a previous issue that says he added support for 'lg' back in August 2018 ... so is it my fault and I do need to update the material-ui dependency?

Do I need to manually put a pixel width to the modal to get rid of that annoying error and make it large like the examples you have on the docs?

Also why would you not support bigger screen sizes for modal maxWidth? Why are we forced to use small modals and we cannot use bigger ones? Computers and laptops are still around in this world no?

thank you so much for clearing my mind, I'm pretty confused by this whole maxWidth issue...

[eps1lon]

This was added in @material-ui/[email protected]. The page always documents the latest version. For old docs see https://material-ui.com/versions/.

Also why would you not support bigger screen sizes for modal maxWidth? Why are we forced to use small modals and we cannot use bigger ones? Computers and laptops are still around in this world no?

We do support it. Just not in older version since we try to follow semver. We also do not backport features to previous major version.

[oliviertassinari]

@bitfede The xl value was added in #13694:
https://github.com/mui-org/material-ui/blob/8612592b8a354300d7e0707956164d92271191b6/packages/material-ui/src/Dialog/Dialog.js#L260

[TheMoonDawg]

Are you sure you didn't install the beta version of Material-UI instead of the new scoped package?

If your package.json says material-ui instead of @material-ui/core, you're on the Beta version, and you'll have to install the scoped package to get the latest version.