-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Outline TextField end adornment margin is too high #14800
Comments
@pladaria Google sign-in page agrees with you: We are introducing a new <TextField
id="outlined-adornment-password"
className={clsx(classes.margin, classes.textField)}
variant="outlined"
type={this.state.showPassword ? 'text' : 'password'}
label="Password"
value={this.state.password}
onChange={this.handleChange('password')}
InputProps={{
endAdornment: (
<InputAdornment position="end">
<IconButton
aria-label="Toggle password visibility"
onClick={this.handleClickShowPassword}
+ edge="end"
>
{this.state.showPassword ? <VisibilityOff /> : <Visibility />}
</IconButton>
</InputAdornment>
),
}}
/> We should update the documentation once #14758 is merged. Do you want to work on it? :) |
i can open a PR for this |
actually |
@d7my11 Right, it seems that the problem was already fixed: https://material-ui.com/components/text-fields/#outlined-input-adornments. It looks alright. What do you mean by "doesn't solve the problem"? |
I'm closing, waiting for more information to be provided. |
@oliviertassinari i thought padding should be less than |
Current Behavior 😯
End adornment right margin is too high when used in outline TextField
Expected
https://material-components.github.io/material-components-web-catalog/#/component/text-field?icons=trailingIcon&type=outlined
Steps to Reproduce 🕹
Demo: https://codesandbox.io/s/009vrmpqvn
The text was updated successfully, but these errors were encountered: