Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slider] focus is not saved on slider after click #15316

Closed
1 of 2 tasks
zhdanouskikh opened this issue Apr 11, 2019 · 2 comments · Fixed by #15439
Closed
1 of 2 tasks

[Slider] focus is not saved on slider after click #15316

zhdanouskikh opened this issue Apr 11, 2019 · 2 comments · Fixed by #15439
Labels
accessibility a11y component: slider This is the name of the generic UI component, not the React module!

Comments

@zhdanouskikh
Copy link

zhdanouskikh commented Apr 11, 2019

When clicking on slider focus should be saved on slider for enabling it for keyboard manipulation. But if navigation to slider by tab key, it has focus and keyboard is working on it.

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior 🤔

  1. click on slider
  2. focus is on slider, slider is highlighted with focused styles

Current Behavior 😯

  1. click on slider
  2. focus is not on slider

Steps to Reproduce 🕹

Link: https://codesandbox.io/s/mj32kjkr6x

  1. click on slider
  2. focus is not set on slider after click

Context 🔦

I would like to have focus on slider after click to have an ability to manipulate with slider by keyboard. It's working now only if you reach slider by tab key.

Your Environment 🌎

Tech Version
Material-UI v3.6.0
Material-UI Lab v3.0.0-alpha.24
React v16.8.1
Browser Google Chrome v 73.0.3683.8 (64bit)
@eps1lon eps1lon added accessibility a11y component: slider This is the name of the generic UI component, not the React module! labels Apr 11, 2019
@eps1lon
Copy link
Member

eps1lon commented Apr 11, 2019

Proposal is following WAI-ARIA Authoring Practices 1.1.

Might be enough to set focus imperatively in the click handler. We need to explore how this should behave with touch devices.

@jztang
Copy link
Contributor

jztang commented Apr 16, 2019

I'd like to work on this if no one else is! I tried out the slider with my touchscreen laptop, and touching the slider thumb does not set focus to it. Should it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants