Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i10n] Improve Russian localization #18421

Closed
1 of 2 tasks
gmltA opened this issue Nov 17, 2019 · 2 comments · Fixed by #18422
Closed
1 of 2 tasks

[i10n] Improve Russian localization #18421

gmltA opened this issue Nov 17, 2019 · 2 comments · Fixed by #18422
Labels
good first issue Great for first contributions. Enable to learn the contribution process.

Comments

@gmltA
Copy link
Contributor

gmltA commented Nov 17, 2019

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

There are some inconsistencies in Russian localization that was introduced recently.

b7cb1c5#diff-4f0ea089313629267bec25abe661453fR130

Current Behavior 😯

Some strings have incorrect translation. Namely:

labelDisplayedRows: ({ from, to, count }) => `${from}-${to === -1 ? count : to} of ${count}`,
clearText: 'чистый',
closeText: 'близко',
loadingText: 'загрузка…',
openText: 'открыто',

Expected Behavior 🤔

Grammatically and semantically correct localization.

labelDisplayedRows: ({ from, to, count }) => `${from}-${to === -1 ? count : to} из ${count}`,
clearText: 'Очистить',
closeText: 'Закрыть',
loadingText: 'Загрузка…',
openText: 'Открыть',
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 17, 2019

@gmltA Thank you for the feedback and for catching it before the actual release. Do you want to submit a pull request? :)

@oliviertassinari oliviertassinari added the good first issue Great for first contributions. Enable to learn the contribution process. label Nov 17, 2019
@gmltA
Copy link
Contributor Author

gmltA commented Nov 17, 2019

@oliviertassinari would love to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Great for first contributions. Enable to learn the contribution process.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants