-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autocomplete] Shift+Home when input has focus should not be prevented. #18488
Comments
It's a duplicate of #18335 |
The fix is not released yet. |
I am still experiencing this issue on the latest build, and wonder if it is perhaps a misunderstanding of desired behaviour around the Home/End keys. At present, when the popper is closed, the user can perform common keyboard shortcuts on the text input:
However, once the popper opens, the function of the Home + End key changes to focus on the popper and:
This prevents the user from being able to edit the text input using Home/End without first closing the popper. Looking at the functionality of other Autocomplete widgets e.g. Google, it seems common that the Home/End keys control the text input field even when the popper is open, to allow the user to adjust the text content. Perhaps a property on Autocomplete could offer an option between the behaviour of the Home/End keys? |
@p00000001 Thank you for this detailed report. I completely agree with you. We have an open issue about it #19500. What do you think of my proposed resolution in #19500 (comment)? Do you want to submit a pull request? :) |
Thanks @oliviertassinari . My apologies that I missed that this was also being discussed in #19500. I think the https://www.w3.org/TR/wai-aria-practices-1.1/#listbox-popup-keyboard-interaction ...it would be great to have it as a standard prop option. I'm only a few weeks into learning React, Javascript, new to GitHub etc. and so there are huge gaps in my knowledge about how to go about implementing an edit on a third party library. However, I've attempted a crash course today and made a pull request #20910. Hopefully it's along the right lines. Unfortunately it has failed on the API doc update - should I not be editing this? |
Current Behavior 😯
I use the Autocomplete, and decide I want to change my value. The cursor is at the end of what I have typed. I want to select all text, and press backspace to clear and start searching again. To make the selection, I use the Shift+Home keyboard shortcut. This does nothing.
Expected Behavior 🤔
Shift+Home should result in all text in the input being selected.
Steps to Reproduce 🕹
Steps:
Context 🔦
The popup menu handling is preventing default on those key events regardless of the modifiers being present.
The text was updated successfully, but these errors were encountered: