[Checkbox][Radio] Custom icon size

[rostislavbobo]

• I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

The [Radio][Checkbox] Add size="small" support has been recently released, which conditionally sets icon fontSize allowing it to have only 'small' or 'default' values without providing any ability to customize it.

It'd be really nice to have the ability to provide a custom fontSize prop to the rendering icons, that will be applied no matter what value contains the size prop

Examples 🌈

We could either allow to specify a custom fontSize while providing an icon

<Checkbox
  icon={<AddCircleOutlinedIcon fontSize="large" />}
  checkedIcon={<CheckIcon fontSize="large" />}
/>

or by adding an extra IconProps prop to [Checkbox] and [Radio] components that will be spreaded over

<Checkbox
  icon={<AddCircleOutlinedIcon />}
  checkedIcon={<CheckIcon />}
  IconProps={{ fontSize: 'large' }}
/>

Motivation 🔦

We all treat Material-UI library as a flexible and extendable tool we could use to build almost every design. Fixing or hardcoding props inside components without providing the way to override a standard behavior is not about this library

[rostislavbobo]

Personally speaking, I prefer the first option, because it provides more flexibility by allowing to specify each case independently, for example

<Checkbox
  icon={<AddCircleOutlinedIcon fontSize="small" />}
  indeterminateIcon={<RemoveIcon />}
  checkedIcon={<CheckIcon fontSize="large" />}
/>

Before I start the implementation, want to be on the same page with the community
Any comments are highly welcomed

[rostislavbobo]

@oliviertassinari , really sorry to disturb you, but I can't find what issue it duplicates. Would appreciate if you could specify that one, thanks in advance

[oliviertassinari]

It's the one related to the support of dynamic and arbitrary props. We link it in the Roadmap. Sorry, I won't have the time to find it.

[rostislavbobo]

Even though I can see what you're talking about, I can't find it in the Roadmap either.

Anyway, I'm offering to fix the lack of flexibility that was recently introduced by adding new functionality, which forces me to add some kludges. The fix won't take much and will bring back the flexibility we had without breaking changes.

If you still think it's better to postpone it, will not object any longer.

Sorry for disturbing you and thank you for your time