Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing @mui/system dependency in @mui/core package #29341

Closed
rtritto opened this issue Oct 27, 2021 · 3 comments · Fixed by #29488
Closed

Missing @mui/system dependency in @mui/core package #29341

rtritto opened this issue Oct 27, 2021 · 3 comments · Fixed by #29488
Labels
bug 🐛 Something doesn't work component: Popper The React component. See <Popup> for the latest version. package: base-ui Specific to @mui/base

Comments

@rtritto
Copy link

rtritto commented Oct 27, 2021

With #28923 Popper was moved from @mui/material to @mui/core (change).
Popper still use @mui/system dependency that it was not added in package.json of @mui/core.

So I got Module not found: Can't resolve '@mui/system' error in @mui\core\Popper\index.js.

Versions:

@mui/material: from 5.0.5 to current 5.1.0

@rtritto rtritto added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 27, 2021
@siriwatknp siriwatknp added bug 🐛 Something doesn't work package: base-ui Specific to @mui/base and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 28, 2021
@South-Paw
Copy link

South-Paw commented Nov 2, 2021

ETA?

I've got a couple of tickets outstanding on this issue & its a relatively straight forward resolution in @mui/core if I'm not mistaken?

@michaldudak
Copy link
Member

The initial idea for the core package was not to depend on the system, but it seems we may not be able to avoid it (cc @mnajdova). I'll try to come up with another solution and will get back to you.

@mnajdova
Copy link
Member

mnajdova commented Nov 2, 2021

Agree, we should not have it as a dependency. We need to find alternative, maybe accept isRtl as a prop in the unstyled version and create a thin wrapper in the @mui/material package that would set it based on the theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Popper The React component. See <Popup> for the latest version. package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants