Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming shadows requires 25 #33167

Closed
2 tasks done
cgarrovillo opened this issue Jun 15, 2022 · 1 comment
Closed
2 tasks done

Theming shadows requires 25 #33167

cgarrovillo opened this issue Jun 15, 2022 · 1 comment
Assignees
Labels
duplicate This issue or pull request already exists

Comments

@cgarrovillo
Copy link

cgarrovillo commented Jun 15, 2022

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

image

When overriding the theme shadows, it needs 25 items in the array.

Expected behavior 🤔

A hard 25 item requirement is too specific.

What if I want 26?

What if I want 1?

Steps to reproduce 🕹

Steps:

  1. Override shadows inside the object passed into createTheme
  2. Watch TS complain

Context 🔦

I'm trying to create a theme which has only a couple shadows

Your environment 🌎

npx @mui/envinfo
  System:
    OS: macOS 12.2.1
  Binaries:
    Node: 14.17.4 - ~/.nvm/versions/node/v14.17.4/bin/node
    Yarn: 1.22.17 - ~/.nvm/versions/node/v14.17.4/bin/yarn
    npm: 6.14.14 - ~/.nvm/versions/node/v14.17.4/bin/npm
  Browsers:
    Chrome: 102.0.5005.115
    Edge: Not Found
    Firefox: 90.0.2
    Safari: 15.3
  npmPackages:
    @emotion/react: ^11.9.0 => 11.9.0 
    @emotion/styled: ^11.8.1 => 11.8.1 
    @mui/base:  5.0.0-alpha.81 
    @mui/icons-material: ^5.6.2 => 5.8.0 
    @mui/lab: ^5.0.0-alpha.80 => 5.0.0-alpha.82 
    @mui/material: ^5.6.2 => 5.8.0 
    @mui/private-theming:  5.8.0 
    @mui/styled-engine:  5.8.0 
    @mui/system:  5.8.0 
    @mui/types:  7.1.3 
    @mui/utils:  5.8.0 
    @mui/x-data-grid: ^5.9.0 => 5.11.0 
    @mui/x-data-grid-pro: ^5.10.0 => 5.11.0 
    @mui/x-date-pickers: ^5.0.0-alpha.3 => 5.0.0-alpha.3 
    @mui/x-license-pro:  5.11.0 
    @types/react: 18.0.6 => 18.0.6 
    react: 18.0.0 => 18.0.0 
    react-dom: 18.0.0 => 18.0.0 
    typescript: 4.6.3 => 4.6.3 

Found on Google Chrome
@cgarrovillo cgarrovillo added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 15, 2022
@mnajdova mnajdova self-assigned this Jun 20, 2022
@mnajdova
Copy link
Member

Duplicate of #28820

@mnajdova mnajdova marked this as a duplicate of #28820 Jun 20, 2022
@mnajdova mnajdova added the duplicate This issue or pull request already exists label Jun 20, 2022
@mnajdova mnajdova removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants