Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy][Select] Select dropdown should not extend beyond the visible page #35706

Closed
2 tasks done
Studio384 opened this issue Jan 2, 2023 · 5 comments
Closed
2 tasks done

[Joy][Select] Select dropdown should not extend beyond the visible page #35706

Studio384 opened this issue Jan 2, 2023 · 5 comments
Assignees
@siriwatknp
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists package: joy-ui Specific to @mui/joy

Comments

@Studio384
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example: https://codesandbox.io/s/mystifying-saha-ypkmu1

Steps:

  1. Create a select with many options
  2. Ope the select

Current behavior 😯

The select dropdown will extend beyond the visible part of the page and require the user to scroll the entire page instead of only the contents of the dropdown.

Expected behavior 🤔

The dropdown cannot become larger than the space between the Select control and the border of the viewport, and becomes scrollable itself without affecting any other content on the page.

Context 🔦

This should have the same behavior as the native select control and the Material UI implementation.

Your environment 🌎

n/a
@Studio384 Studio384 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 2, 2023
@michaldudak michaldudak added component: select This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jan 2, 2023
@siriwatknp siriwatknp added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 3, 2023
@siriwatknp
Copy link
Member

siriwatknp commented Jan 3, 2023 •
edited
Loading

Thanks for the feedback. This could be fixed by applying maxHeight and overflow to the Select's listbox slot. Will open a PR soon.

@sai6855 sai6855 mentioned this issue Feb 21, 2023
Closed
1 task
@sai6855
Copy link
Contributor

sai6855 commented Feb 21, 2023

@siriwatknp created PR for this issue #36286

@siriwatknp
Copy link
Member

@sai6855 This PR #36156 will fix this issue

@siriwatknp
Copy link
Member

duplicate #36115

@siriwatknp siriwatknp added the duplicate This issue or pull request already exists label Feb 22, 2023
@sai6855
Copy link
Contributor

sai6855 commented Feb 22, 2023

No problem,Since no pr is linked to issue I thought no one is working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Select][Joy] fix overflow sai6855/material-ui
4 participants
@Studio384 @michaldudak @siriwatknp @sai6855