Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Some components still use Joy[Component] class name instead of Mui[Component] #36082

Closed
2 tasks done
Bestwebdesign opened this issue Feb 6, 2023 · 6 comments
Closed
2 tasks done
Assignees
Labels
bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy

Comments

@Bestwebdesign
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:
https://codesandbox.io/s/sad-nightingale-lqil0l?file=/demo.js

Steps:

  1. Inspect class names using console

Current behavior 😯

The class names still have "Joy" prefix:
JoyGrid-root JoyGrid-container JoyGrid-direction-xs-row
JoyStack-root
JoyBox-root

Also the documentation contains wrong class names:
https://mui.com/joy-ui/react-card/#anatomy (JoyCard-root instead of MuiCard-root)
https://mui.com/joy-ui/react-grid/#anatomy (JoyGrid-root instead of MuiGrid-root)
https://mui.com/joy-ui/react-grid/#anatomy (JoyStack-root instead of MuiStack-root)

Expected behavior 🤔

According to #35718 class names should be prefixed with "Mui":
MuiGrid-root MuiGrid-container MuiGrid-direction-xs-row
MuiStack-root
MuiBox-root

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@Bestwebdesign Bestwebdesign added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 6, 2023
@Bestwebdesign Bestwebdesign changed the title [Joy] Some components still use [Joy][Component] class name instead of Mui[Component] [Joy] Some components still use Joy[Component] class name instead of Mui[Component] Feb 6, 2023
@zannager zannager added the package: joy-ui Specific to @mui/joy label Feb 7, 2023
@badalsaibo
Copy link
Contributor

I like having the Joy prefix for clear distinction between Mui and Joy

@siriwatknp siriwatknp added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 8, 2023
@siriwatknp
Copy link
Member

@Bestwebdesign Nice catch! do you want to submit a PR?

@siriwatknp
Copy link
Member

I like having the Joy prefix for clear distinction between Mui and Joy

The conclusion is to go with Mui-* for all core products (Material UI, Joy UI, and MUI Base) and separate Joy UI with Mui-joy class name.

@Bestwebdesign
Copy link
Contributor Author

@siriwatknp I wasn't able to find the cause of this bug, so I leave it to the expert.

@sai6855
Copy link
Contributor

sai6855 commented Feb 13, 2023

@siriwatknp created PR which should close part of this issue. #36167

@ZeeshanTamboli
Copy link
Member

Fixed in #36167. Docs will be updated in #36210.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: joy-ui Specific to @mui/joy
Projects
None yet
Development

No branches or pull requests

6 participants