Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] Include new twitter icon X #38480

Open
edx-mostafa-eltahawy opened this issue Aug 15, 2023 · 17 comments
Open

[icons] Include new twitter icon X #38480

edx-mostafa-eltahawy opened this issue Aug 15, 2023 · 17 comments
Assignees
Labels
new feature New feature or request package: icons Specific to @mui/icons

Comments

@edx-mostafa-eltahawy
Copy link

edx-mostafa-eltahawy commented Aug 15, 2023

Summary 💡

The current twitter icon available under MUI is the old logo

Examples 🌈

The current twitter icon available under MUI is the old logo
TwitterIcon from '@mui/icons-material/Twitter';

Motivation 🔦

The current twitter icon available under MUI is the old logo

@edx-mostafa-eltahawy edx-mostafa-eltahawy added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 15, 2023
@zannager zannager added the package: icons Specific to @mui/icons label Aug 15, 2023
@mj12albert mj12albert changed the title Include new twitter icon X [icons] Include new twitter icon X Aug 15, 2023
@mj12albert mj12albert removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 15, 2023
@abreel
Copy link
Contributor

abreel commented Aug 19, 2023

@siriwatknp This is my first open source contribution and I want to try looking into this issue. Is that fine?

@siriwatknp
Copy link
Member

@abreel Thanks for that! If you are interested, the PR is already open. Can you please take a look if it looks good to you? #38343

@abreel
Copy link
Contributor

abreel commented Aug 21, 2023

Thanks @siriwatknp

I will like to know which of the images I should use

Screenshot 2023-08-21 at 11 35 37

as the new icon

Screenshot 2023-08-21 at 11 37 10

@abreel
Copy link
Contributor

abreel commented Aug 21, 2023

Thanks @siriwatknp

I will like to know which of the images I should use

Screenshot 2023-08-21 at 11 35 37 as the new icon Screenshot 2023-08-21 at 11 37 10

They are svg icons

@edx-mostafa-eltahawy
Copy link
Author

Thanks @siriwatknp
I will like to know which of the images I should use
Screenshot 2023-08-21 at 11 35 37
as the new icon
Screenshot 2023-08-21 at 11 37 10

They are svg icons

I believe the filled one on the right as the current twitter logo is only present in the filled variant as well.

@abreel

This comment was marked as resolved.

@abreel
Copy link
Contributor

abreel commented Aug 23, 2023

I have made the needed changes, but honestly don't know where or how to preview. Is there a documentation that could help with checking my changes in the codebase?

@edx-mostafa-eltahawy @siriwatknp

@abreel
Copy link
Contributor

abreel commented Aug 23, 2023

I have used yarn to install dependencies and tried running the server, but I can't work my way around checking the twitter icon. Any help will be appreciated

@edx-mostafa-eltahawy
Copy link
Author

I have used yarn to install dependencies and tried running the server, but I can't work my way around checking the twitter icon. Any help will be appreciated

Contributing Guide

@edx-mostafa-eltahawy

This comment was marked as outdated.

@abreel
Copy link
Contributor

abreel commented Sep 2, 2023

@edx-mostafa-eltahawy I have tried everything I could think of and still honestly can't find my way around the viewing the icon. I have updated the icon svg file at packages/mui-icons-material/custom/Twitter.js, but I still can't see it change in the browser

Screenshot 2023-09-02 at 07 33 04 and even the localhost:3000/playground returns "not found" Screenshot 2023-09-02 at 08 10 18 Screenshot 2023-09-02 at 08 10 35

@abreel
Copy link
Contributor

abreel commented Sep 5, 2023

@edx-mostafa-eltahawy @siriwatknp I made a pr to the master branch already

@IN2TEC
Copy link

IN2TEC commented Oct 5, 2023

Hey guys, is the new icon up in the libary? I am having difficulties finding it

@eriq123
Copy link

eriq123 commented Oct 5, 2023

Hey guys, is the new icon up in the libary? I am having difficulties finding it

You can check the Twitter icon update here #38811

@iamchandanys
Copy link

Any idea when the new Twitter icon will be out?

@oliviertassinari
Copy link
Member

oliviertassinari commented Dec 15, 2023

#38811 is a step in the right direction but doesn't deliver value.

I think there are more follow-ups needed on this to consider the problem solved:

  • 3. In a few years, once enough of the Twitter brand is gone, remove the icon.

Sorry, something went wrong.

@harsh-ps-2003

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request package: icons Specific to @mui/icons
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants