-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[icons] Include new twitter icon X #38480
Comments
@siriwatknp This is my first open source contribution and I want to try looking into this issue. Is that fine? |
Thanks @siriwatknp I will like to know which of the images I should use ![]() as the new icon ![]() |
They are svg icons |
I believe the filled one on the right as the current twitter logo is only present in the filled variant as well. |
This comment was marked as resolved.
This comment was marked as resolved.
I have made the needed changes, but honestly don't know where or how to preview. Is there a documentation that could help with checking my changes in the codebase? |
I have used yarn to install dependencies and tried running the server, but I can't work my way around checking the twitter icon. Any help will be appreciated |
|
This comment was marked as outdated.
This comment was marked as outdated.
@edx-mostafa-eltahawy I have tried everything I could think of and still honestly can't find my way around the viewing the icon. I have updated the icon svg file at packages/mui-icons-material/custom/Twitter.js, but I still can't see it change in the browser ![]() ![]() ![]() |
@edx-mostafa-eltahawy @siriwatknp I made a pr to the master branch already |
Hey guys, is the new icon up in the libary? I am having difficulties finding it |
You can check the Twitter icon update here #38811 |
Any idea when the new Twitter icon will be out? |
#38811 is a step in the right direction but doesn't deliver value. I think there are more follow-ups needed on this to consider the problem solved:
![]()
|
Summary 💡
The current twitter icon available under MUI is the old logo
Examples 🌈
The current twitter icon available under MUI is the old logo
TwitterIcon from '@mui/icons-material/Twitter';
Motivation 🔦
The current twitter icon available under MUI is the old logo
The text was updated successfully, but these errors were encountered: