[docs-infra] Strange styles applied to Markdown blockquotes

[mapache-salvaje]

I never noticed this before, but the blockquotes on this page have some funky styles applied to them:

• The first blockquote has a double quote appended to it, but the second only has a single quote for some reason
• There's some weird extra space added to the text that's in code-blocks
  • This space only seems to be applied in the context of the blockquote - it doesn't happen if the code block is italicized outside of the blockquote

We pretty much never use blockquotes in the docs—they were phased out in favor of more informative callouts—but they should still look nice when they are present. 😁

In any case, this particular page does not need blockquotes, so I'm going to open a PR to replace this instance with a warning or error callout.

[danilo-leal]

Uhm... this is weird — not exactly sure about the reason for the single quote there. 🤔 The extra space within the code block seems to be coming from the text-indent property. I'll check it out; appreciate you for reporting!

As a bit of context, we used <blockquotes> for callouts before having the :::success syntax. After implementing that, I changed the quote tag styles to properly convey a citation extract, something pulled out from some source, hence this specific style. But in the screenshot's case, it's indeed more appropriate to use a proper callout 👌

[oliviertassinari]

I think we can close this issue. We are not supposed to have code in quotes.

[danilo-leal]

This issue is still valid, as even though I agree this scenario shouldn't happen, it should also not get broken! 😄 Overall, the blockquote element is still nice to be preserved and reserved for whenever we want to share actual citations.

There might be hidden instances of it being used for callouts, though, as that was our previous solution for it. Sam has specifically fixed, in the above-linked PR, the one from the screenshot so that's all good. But I still have to figure out what's messing up the quote styles — I have a hunch it's something to do with the text indentation property I'm using to push content from the first line to the right.

[oliviertassinari]

There is only one place in the docs that takes advantage of quotes (to my knowledge)

https://mui.com/material-ui/guides/api/

[danilo-leal]

Closing this issue as this problem should be fixed by #40347. Here's a quick before

and after

— changing the blockquote's content from open-quotes to “ seemed to do the trick!

[oliviertassinari]

@danilo-leal 👌