Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Sign-in side template image not loading (503 error) #42649

Closed
onlinejudge95 opened this issue Jun 15, 2024 · 8 comments
Closed

[docs] Sign-in side template image not loading (503 error) #42649

onlinejudge95 opened this issue Jun 15, 2024 · 8 comments
Assignees
Labels
support: docs-feedback Feedback from documentation page

Comments

@onlinejudge95
Copy link

onlinejudge95 commented Jun 15, 2024

Related page

https://mui.com/material-ui/getting-started/templates/sign-in-side/

Kind of issue

Broken demo

Issue description

When I open the live demo for the Sign-in side template I don't see the background image loading up.
On checking the network tab, there is a 503 error with the wallpaper service.

material-ui-bug

Context

No response

Search keywords: template

@onlinejudge95 onlinejudge95 added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Jun 15, 2024
@mbrookes mbrookes changed the title [docs] [docs] Sign-in side template image not loading (503 error) Jun 15, 2024
@mbrookes
Copy link
Member

https://source.unsplash.com/random?wallpapers

image

I imagine it's a transient error and will come back...

@mbrookes mbrookes removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 15, 2024
@zanivan
Copy link
Contributor

zanivan commented Jun 17, 2024

Hey @onlinejudge95 nice catch! As @mbrookes said, it seems to be an issue with the Unsplash URL, and hopefully, it'll come back.

Fortunately, this has been fixed on the revamped templates—however, it's only available on the next branch for now. Is it worth adding a fix in the master branch if the Unsplash URL doesn't return @mnajdova @DiegoAndai?

@onlinejudge95
Copy link
Author

@zanivan I did raise the same to the Unsplash team, let's see if they revert, nevertheless v5 is not going to be deprecated and since this is present in the Getting Started section of the doc, I would be in favor of fixing this.

@mnajdova
Copy link
Member

Fortunately, this has been fixed on the revamped templates—however, it's only available on the next branch for now. Is it worth adding a fix in the master branch if the Unsplash URL doesn't return @mnajdova @DiegoAndai?

I would honestly avoid this. If we do this, we will have to update the styled() calls to match the syntax for v5 (I mean the one compatible with ^5.0.0). I honestly do not think it's worth it.

@onlinejudge95
Copy link
Author

onlinejudge95 commented Jun 18, 2024

@mbrookes Unsplash team replied that they are not going to fix this API(sources.unsplash.com), and instead want to onboard to a separate API `

@mnajdova then I would suggest any one of these

  • Use the updated Unsplash API
  • Remove the demo
  • Rename the demo

API links

unsplash-api

@mnajdova
Copy link
Member

Use the updated Unsplash API

@zanivan it makes sense to do this

@zanivan
Copy link
Contributor

zanivan commented Jun 19, 2024

Would a static image work instead? I wonder if it's worth using an API just to randomize the wallpaper in the template. Maybe a local static image would be more future-proof, in my opinion.

@onlinejudge95
Copy link
Author

It is better to use a local image.

I tried updating the doc with the new API but the Unsplash team has made this an authenticated route now, I don't see the point of integrating an authenticated API just for a template in the demo site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
support: docs-feedback Feedback from documentation page
Projects
None yet
Development

No branches or pull requests

4 participants