Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CircularProgress] Only works with Chrome #5524

Closed
pradel opened this issue Nov 8, 2016 · 13 comments
Closed

[CircularProgress] Only works with Chrome #5524

pradel opened this issue Nov 8, 2016 · 13 comments
Assignees
Labels
bug 🐛 Something doesn't work component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module!

Comments

@pradel
Copy link
Contributor

pradel commented Nov 8, 2016

Circular progress doesn't work on safari, it looks full.

Open next docs in safari.
capture d ecran 2016-11-08 a 23 17 39

Versions

  • Material-UI: Next branch
  • Browser: Safari 9.1.3, 10.1; Firefox 45.8.0
@pradel pradel changed the title [Circular Progress][Next] Doesn't work on safari [Next][Circular Progress] Doesn't work on safari Nov 9, 2016
@oliviertassinari oliviertassinari added next bug 🐛 Something doesn't work component: CircularProgress The React component labels Nov 9, 2016
@ghost
Copy link

ghost commented Dec 20, 2016

Seems that calc() in stroke-dasharray doesn't work in Safari and Firefox:
CodePen example.

@mbrookes mbrookes changed the title [Next][Circular Progress] Doesn't work on safari [Circular Progress] Doesn't work on safari Jan 15, 2017
@slavab89
Copy link
Contributor

Should be able to fix it using jss fallbacks i think. But not sure how to make it dynamic with the current style prop? Or should i want for you to update jss to the latest version (along with jss-theme-reactor?) to introduce the dynamic changes?

Also, i didnt find any documentation regarding willChange that you're using. What is it for?

@mbrookes
Copy link
Member

@oliviertassinari Looks like another use-case for jss dynamic styles.

@kazazor
Copy link
Contributor

kazazor commented Jun 20, 2017

This is also happening on FF (could be also on Edge & IE but I don't have them to test on..)

@oliviertassinari oliviertassinari changed the title [Circular Progress] Doesn't work on safari [Circular Progress] Doesn't work on Safari and Firefox Jun 20, 2017
@oliviertassinari oliviertassinari changed the title [Circular Progress] Doesn't work on Safari and Firefox [CircularProgress] Doesn't work on Safari and Firefox Jun 20, 2017
@oliviertassinari
Copy link
Member

Same story on IE11 and Edge 14. Only working with Chrome then 🙈 .

@oliviertassinari oliviertassinari changed the title [CircularProgress] Doesn't work on Safari and Firefox [CircularProgress] Only works with Chrome Jun 20, 2017
@kazazor
Copy link
Contributor

kazazor commented Jun 20, 2017

FYI - the bug in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1258270

@kazazor
Copy link
Contributor

kazazor commented Jun 25, 2017

My 2 cents on the issue, it probably should be prioritized very high cause it's better to have fewer components to be used than having some which do not work on all browsers except 1 :)

I'll try to see if I have some time to give it a try but probably gonna be hard to find some

@oliviertassinari
Copy link
Member

but probably gonna be hard to find some

Same here.

@arsen
Copy link

arsen commented Jul 12, 2017

I have implemented a fallback function in JS for CSS calc, which works fine.
But :(
That fallback function needs the size of the component, which will come with JSS dynamic styles if we update the JSS and ThemeReactor to the latest version. In that case, it will grab it from components "props" and use it.

The bug in Firefox has been reported a year ago and still not fixed, so I think that we should use some kind of JS fallback until it is fixed on the browsers side.

Here are my changes (the "size" property of the component is hardcoded for now):
arsen@a8a3527

@kazazor
Copy link
Contributor

kazazor commented Jul 20, 2017

That fallback function needs the size of the component, which will come with JSS dynamic styles if we update the JSS and ThemeReactor to the latest version. In that case, it will grab it from components "props" and use it.

@arsen / @oliviertassinari - what are the consequences of upgrading those to the latest version? Is that a good path to give with?

@oliviertassinari
Copy link
Member

@kazazor I'm working on upgrading JSS. That could be our first use case for the dynamic CSS feature of JSS. I will try to support it.

@slavab89
Copy link
Contributor

slavab89 commented Sep 8, 2017

Should be possible to move forward with this once #7633 is done (Linking for reference and tracking)
Would it be correct to access the created sheet from withStyles in the component so that it will be possible to do update on it?

@eugenesaenko
Copy link

Got this issue on Safari 11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: CircularProgress The React component component: progress This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

7 participants