Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] Preserve time component of Date #5743

Closed
at0g opened this issue Dec 9, 2016 · 1 comment
Closed

[DatePicker] Preserve time component of Date #5743

at0g opened this issue Dec 9, 2016 · 1 comment
Labels
component: date picker This is the name of the generic UI component, not the React module!

Comments

@at0g
Copy link

at0g commented Dec 9, 2016

Description

Whenever a Date is chosen in the DatePicker, it defaults the time to midnight.
While this behaviour may be desirable in some situations, it's a nuisance when trying to work with both a DatePicker and a TimePicker (seeing as there is no unified DateTimePicker).

A couple of points:

  • The Date object contains both the calendar date components along with time/tz components.
  • The DatePicker operates on the calendar date components of the Date object, it probably should not mess with the time (at the very least, this should be a configuration option)
  • The TimePicker does not reset the calendar part of the date back to 1/1/1970 when a time is chosen
@oliviertassinari oliviertassinari added the component: date picker This is the name of the generic UI component, not the React module! label Dec 18, 2016
@oliviertassinari oliviertassinari changed the title DatePicker: Preserve time component of Date [DatePicker] Preserve time component of Date Dec 18, 2016
@oliviertassinari
Copy link
Member

Closing for #4787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: date picker This is the name of the generic UI component, not the React module!
Projects
None yet
Development

No branches or pull requests

3 participants