Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dialog] Cannot override styles #9258

Closed
croraf opened this issue Nov 21, 2017 · 1 comment
Closed

[Dialog] Cannot override styles #9258

croraf opened this issue Nov 21, 2017 · 1 comment
Labels
component: dialog This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.

Comments

@croraf
Copy link
Contributor

croraf commented Nov 21, 2017

Current Behavior

Expected Behavior


              <Dialog
                        title='Make transaction'
                        modal={false}
                        open={this.state.open}
                        onRequestClose={this.handleClose}
                        actions={<RemoteSubmitButton handleClose={this.handleClose}/>}
                        contentStyle={{width: '95%', maxWidth: '1400px'}}
                        bodyStyle={{maxHeight: '250px', overflowY: 'auto'}}
                        style={{marginTop: '-200px', paddingTop: '100px'}}>
                        
                        <div />
                        
                </Dialog>

image

With style attribute of Dialog I want to set the style of the root element.
The marginTop attribute is set but paddingTop is not, instead internal paddingTop is used and cannot be overriden with style={{}}.
I should be able to override the styles of dialog.

Your Environment

Tech Version
Material-UI v0.19.4
@mbrookes
Copy link
Member

@croraf We're focusing on the v1-beta branch. Style overriding is much improved there. Since Dialog is migrated, I'm closing this issue, but if you would like to submit a PR to improve this on the master branch, feel free.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: dialog This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: dialog This is the name of the generic UI component, not the React module! package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5.
Projects
None yet
Development

No branches or pull requests

4 participants