From 9cd7c3b4e3bffc9c1371a29ae22dc2c2e08b611a Mon Sep 17 00:00:00 2001 From: Minh Nguyen Date: Tue, 7 Apr 2020 08:49:10 +0100 Subject: [PATCH] [Dialog] Fix TypeScript type for `children` Fixes https://github.com/mui-org/material-ui/issues/20441#issuecomment-610227931 --- packages/material-ui/src/Dialog/Dialog.d.ts | 2 +- packages/material-ui/src/Dialog/Dialog.spec.tsx | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 packages/material-ui/src/Dialog/Dialog.spec.tsx diff --git a/packages/material-ui/src/Dialog/Dialog.d.ts b/packages/material-ui/src/Dialog/Dialog.d.ts index 7815dd3daef02f..d5a28a84ccde8c 100644 --- a/packages/material-ui/src/Dialog/Dialog.d.ts +++ b/packages/material-ui/src/Dialog/Dialog.d.ts @@ -17,7 +17,7 @@ export interface DialogProps /** * Dialog children, usually the included sub-components. */ - children: React.ReactNode; + children?: React.ReactNode; /** * If `true`, clicking the backdrop will not fire the `onClose` callback. */ diff --git a/packages/material-ui/src/Dialog/Dialog.spec.tsx b/packages/material-ui/src/Dialog/Dialog.spec.tsx new file mode 100644 index 00000000000000..b4afee6b22ee45 --- /dev/null +++ b/packages/material-ui/src/Dialog/Dialog.spec.tsx @@ -0,0 +1,6 @@ +import * as React from 'react'; +import { Dialog } from '@material-ui/core'; + +function optionalChildrenTest() { + ; +}