Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] slots for PieArcLabelPlot defined in PieArcLabelPlotSlots but never passed down from PieChart #12756

Closed
abeanater opened this issue Apr 12, 2024 · 4 comments · Fixed by #12806
Assignees
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!

Comments

@abeanater
Copy link

abeanater commented Apr 12, 2024

Steps to reproduce

Link to live example: (required)

Steps:

  1. Try adding custom pieArcLabel component to slots prop of PieChart although defined in types its never propagated down into PieArcLabelPlot

Current behavior

User expects to be able to use custom PieArcLabel component as its defined in the slots. They add it but it doesnt work as its not passed into the PieArcLabelPlot component.

Expected behavior

If you set pieArcLabel slot prop it should propagate down and use your custom label.

Context

I was hoping to add functionality like different colors, rotating the text, etc of a pieArcLabel. I expected to be able to use this slot but I could not.

Your environment

NA. This is just from a code perspective.

Search keywords: PieArcLabelPlotSlots, PieArcLabelPlot, slots

@abeanater abeanater added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Apr 12, 2024
@zannager zannager added the component: charts This is the name of the generic UI component, not the React module! label Apr 12, 2024
@michelengelen michelengelen changed the title slots for PieArcLabelPlot defined in PieArcLabelPlotSlots but never passed down from PieChart [charts] slots for PieArcLabelPlot defined in PieArcLabelPlotSlots but never passed down from PieChart Apr 15, 2024
@michelengelen
Copy link
Member

hey @abeanater and thanks for raising this.
I did add this to our board so the team can have a look!

@michelengelen michelengelen added bug 🐛 Something doesn't work and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Apr 15, 2024
@JCQuintas
Copy link
Member

Hi @abeanater, from a quick test it indeed looks like neither the slotProps nor the slots are being passed on. I'll look into it as soon as possible.

@abeanater
Copy link
Author

@JCQuintas Thanks for taking a look! Yes it was both the slotProps in addition to the slots. It looks like the PieArcLabelPlot is ready for it. It just needs to be passed on down.

Copy link

⚠️ This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@abeanater: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants