-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data grid] V7 CSV export regression for undefined
and null
values
#14082
Comments
Hey @milotoor ... I can confirm the regression! Thanks for raising this. const valueStr = typeof value === 'string' ? value : `${value}`; It should probably include an early return like this: if (value == null) {
return '';
}
const valueStr = typeof value === 'string' ? value : `${value}`; @flaviendelangle ^^ 😛 |
Hey @michelengelen, just ran into this issue and it's a bit of blocker for an upcoming release. Any updates on timing for a fix would help a lot in our release planning. Thanks Order ID: 93310 |
@cmeyer-kareo ... I understand that and we can assure you that this will be fixed as soon as our team has the capacity to do so. If you need it faster for your release you are free to open up a PR to fix this yourself! We always appreciate contributions from our community |
This PR will fix that #14166 :) |
@milotoor: How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey. |
Latest version
Steps to reproduce
Link to live examples:
Steps:
undefined
and its "Trader Name" column saysnull
Current behavior
When a table row has a column whose value is
undefined
ornull
the corresponding cell of the CSV readsundefined
ornull
, respectively.Expected behavior
The corresponding cell value should be blank.
Context
In the v6 DataGrid, when a table row has a column whose value was
undefined
ornull
the corresponding row of the CSV would be blank. After migrating to v7 it seems that this behavior was lost, as the cells now contain the textundefined
andnull
, respectively.It's unclear if this was intentional or not, as there's no mention of this in the v6 to v7 migration guide. If it was intentional, I think this constitutes a breaking change and should be added to the guide.
Your environment
npx @mui/envinfo
Search keywords: DataGrid v7 CSV export undefined null
Order ID: 87847
The text was updated successfully, but these errors were encountered: