Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid scrolls when pressing space bar if editing enabled #14713

Open
laikai0000 opened this issue Sep 24, 2024 · 1 comment
Open

Datagrid scrolls when pressing space bar if editing enabled #14713

laikai0000 opened this issue Sep 24, 2024 · 1 comment
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Editing Related to the data grid Editing feature

Comments

@laikai0000
Copy link

laikai0000 commented Sep 24, 2024

Summary

Current behavior 😯
The datagrid jumps/scrolls when an editable cell is selected and the space bar is pushed.
Expected behavior 🤔
The datagrid should not scroll and either:
Pressing the space bar has the identical effect to a double-click or pressing enter on a selected cell

Examples

No response

Motivation

No response

Search keywords: DataGrid
Order ID: 11111

@laikai0000 laikai0000 added new feature New feature or request status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 24, 2024
@MBilalShafi
Copy link
Member

MBilalShafi commented Sep 24, 2024

Hey @laikai0000

Once you are in edit mode (by 1. double click, 2. pressing enter, 3. starting typing), you could add space afterward. Isn't that working for you like this?

Or your request is to trigger edit mode when the user presses Space key on an editable cell currently not in edit mode?
I think that would be the reverse of #8180

This is an interesting discussion though and has also been raised previously. I couldn't find the ideal behavior according to the ARIA spec, I'd personally prefer not to let the user activate edit mode on the Space key as I'd generally not expect users to start typing from Space character.

Open to suggestions though, could be a behavioral change candidate for v8.

CC @mui/xgrid

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! feature: Editing Related to the data grid Editing feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 24, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Needs refinement in MUI X Data Grid Sep 24, 2024
@MBilalShafi MBilalShafi added enhancement This is not a bug, nor a new feature and removed new feature New feature or request labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Editing Related to the data grid Editing feature
Projects
Status: 🆕 Needs refinement
Development

No branches or pull requests

2 participants