Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Make useChartGradientId hooks public #16095

Closed
JCQuintas opened this issue Jan 7, 2025 · 1 comment · Fixed by #16106
Closed

[charts] Make useChartGradientId hooks public #16095

JCQuintas opened this issue Jan 7, 2025 · 1 comment · Fixed by #16106
Assignees
@JCQuintas
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature v8.x

Comments

@JCQuintas
Copy link
Member

Maybe with a renaming like useChartGetGradientId and useChartGetGradientIdObjectBound and a nice JSDocs comment. Otherwise it looked like the hook returns the gradient itself

Originally posted by @alexfauquette in #15733 (comment)
@JCQuintas JCQuintas self-assigned this Jan 7, 2025
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 7, 2025
@JCQuintas JCQuintas added enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! v8.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 7, 2025
This was referenced Jan 7, 2025
Merged
Merged
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JCQuintas JCQuintas

Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[charts] Make useChartGradientId public JCQuintas/mui-x
1 participant
@JCQuintas