Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] The drag event on head should be ignored when disableColumnReorder #1762

Closed
sajidfrommerqata opened this issue May 20, 2021 · 4 comments · Fixed by #1952
Closed

[DataGrid] The drag event on head should be ignored when disableColumnReorder #1762

sajidfrommerqata opened this issue May 20, 2021 · 4 comments · Fixed by #1952
Assignees
@m4theushw
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!

Comments

@sajidfrommerqata
Copy link

I set disableColumnReorder to true but I can reorder the columns of the table.

Video: https://drive.google.com/file/d/15TAR8d_aED1OVNETtdPkSml4IKRfSt4w/view
SandBox: https://codesandbox.io/s/material-demo-forked-7hvfc
@mnajdova mnajdova changed the title disableColumnReorder not working [DataGrid] disableColumnReorder not working May 21, 2021
@ZeeshanTamboli
Copy link
Member

ZeeshanTamboli commented May 24, 2021 •
edited
Loading

@sajidfrommerqata I am wondering as to how is this working for you as shown in the video? Did you try XGrid component first and then swapped it with DataGrid? Can you refresh codesandbox link and try again? It does not work for me in the provided CodeSandbox link. My OS is MacOS.

Also, disableColumnReorder is not available on MIT version. You need to upgrade to the XGrid component to unlock this feature.

@eps1lon eps1lon transferred this issue from mui/material-ui May 24, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! labels May 24, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented May 24, 2021 •
edited
Loading

I have raised the same bug in #1579. It's more a less a duplicate.

@ZeeshanTamboli
Copy link
Member

@oliviertassinari The user is mentioning it is in DataGrid for which we do not support column reordering. Did you check the provided codesandbox link and video? I cannot reproduce it there.

@oliviertassinari
Copy link
Member

oliviertassinari commented May 25, 2021 •
edited
Loading

@ZeeshanTamboli I could reproduce the issue with the codesandbox provided here.

@oliviertassinari oliviertassinari changed the title [DataGrid] disableColumnReorder not working [DataGrid] The drag event on head should be ignored when disableColumnReorder={true} May 30, 2021
@oliviertassinari oliviertassinari changed the title [DataGrid] The drag event on head should be ignored when disableColumnReorder={true} [DataGrid] The drag event on head should be ignored when disableColumnReorder May 30, 2021
@oliviertassinari oliviertassinari mentioned this issue May 30, 2021
Closed
2 tasks
@oliviertassinari oliviertassinari mentioned this issue Jun 17, 2021
Closed
@m4theushw m4theushw mentioned this issue Jun 21, 2021
Merged
@m4theushw m4theushw self-assigned this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@m4theushw m4theushw

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Ignore drag events when disableColumnReorder is true m4theushw/mui-x
4 participants
@oliviertassinari @ZeeshanTamboli @m4theushw @sajidfrommerqata