Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Remove custom dark mode scrollbar in v5 #1805

Closed
1 task done
oliviertassinari opened this issue May 31, 2021 · 2 comments · Fixed by #3146
Closed
1 task done

[DataGrid] Remove custom dark mode scrollbar in v5 #1805

oliviertassinari opened this issue May 31, 2021 · 2 comments · Fixed by #3146
Assignees
@alexfauquette
Labels
component: data grid This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented May 31, 2021 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Summary 💡

The current custom dark mode scrollbar implementation suffers from the same issue as mui/material-ui#23520. It forces a width on the scrollbar on macOS, it also doesn't respect the native dark mode style.
A better solution was found in mui/material-ui#25016 (comment).

Motivation 🔦

We should remove:

https://github.com/mui-org/material-ui-x/blob/40ebf9b4079dd7433200b7de00b6959fd25a50ec/packages/grid/_modules_/grid/components/containers/GridRootStyles.ts#L353-L378

once mui/material-ui#25016 is fixed and we have updated the repo to dependant on v5.

See #1613 for a related issue.
@oliviertassinari oliviertassinari added on hold There is a blocker, we need to wait new feature New feature or request labels May 31, 2021
@oliviertassinari oliviertassinari mentioned this issue Jun 1, 2021
Closed
2 tasks
@oliviertassinari oliviertassinari mentioned this issue Aug 21, 2021
Closed
2 tasks
@alexgonch
Copy link
Contributor

@oliviertassinari What's the status on this issue? I've ran into several problems related to dark mode scrollbars that are particularly prominent with the DataGrid component. It sounds like the fix outlined above would be a perfect solution.

@m4theushw m4theushw mentioned this issue Oct 13, 2021
Closed
@m4theushw m4theushw added component: data grid This is the name of the generic UI component, not the React module! and removed on hold There is a blocker, we need to wait labels Nov 9, 2021
@m4theushw
Copy link
Member

mui/material-ui#25016 was fixed. This issue is now unblocked. Anybody feel free to submit a PR.

@m4theushw m4theushw added the good first issue Great for first contributions. Enable to learn the contribution process. label Nov 9, 2021
@alexfauquette alexfauquette self-assigned this Nov 9, 2021
@alexfauquette alexfauquette mentioned this issue Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexfauquette alexfauquette

Labels
component: data grid This is the name of the generic UI component, not the React module! good first issue Great for first contributions. Enable to learn the contribution process. new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Use color-scheme to set dark mode on native components alexfauquette/mui-x
4 participants
@oliviertassinari @alexgonch @m4theushw @alexfauquette