Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Calendar icon is almost invisible when in dark mode #2855

Closed
2 tasks done
zzossig opened this issue Oct 13, 2021 · 2 comments · Fixed by mui/material-ui#29454
Closed
2 tasks done

[DataGrid] Calendar icon is almost invisible when in dark mode #2855

zzossig opened this issue Oct 13, 2021 · 2 comments · Fixed by mui/material-ui#29454
Assignees
@flaviendelangle
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!

Comments

@zzossig
Copy link
Contributor

zzossig commented Oct 13, 2021

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Current behavior 😯

Screen Shot 2021-10-13 at 8 15 01 PM

When a date cell is in edit mode, calendar icon is almost invisible when in dark mode.

Expected behavior 🤔

Icon color should be changed when in dark mode.

Steps to reproduce 🕹

Steps:

Context 🔦

No response

Your environment 🌎

`npx @mui/envinfo` 
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID 💳 (optional)

#27772
@zzossig zzossig added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 13, 2021
@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 13, 2021
@flaviendelangle
Copy link
Member

flaviendelangle commented Oct 13, 2021 •
edited
Loading

https://stackoverflow.com/questions/62162645/change-color-of-chromes-calendar-icon-in-html-date-input

It is the browser icon and it does not follow our theme.
I have a quick fix to have it turn to white when in dark mode. It's not perfect but at least it would be readable.
I'm checking with the team managing this component if they have a better fix to apply on their side 👍

@flaviendelangle flaviendelangle self-assigned this Oct 13, 2021
@flaviendelangle flaviendelangle mentioned this issue Oct 13, 2021
Closed
@m4theushw
Copy link
Member

This can be solved with mui/material-ui#25016.

@alexfauquette alexfauquette mentioned this issue Nov 1, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
3 participants
@flaviendelangle @m4theushw @zzossig