[DateTimePickers] Remove the calendar/clock tabs

[alexfauquette]

The problem

The new Date Time Picker component show the tabs calendar/clock. So when you click on it, you expect to see the clock which has been removed

Screencast.from.07-12-2022.10.17.07.mp4

The expected behavior

If there is no clock, it should not have a Tabs in the view

[LukasTy]

I'm not certain we should.

1. Clicking on time tab does change the focused section to hours
2. We are going to bring back the visual time selection behaviour eventually

I would be curious to hear @joserodolfofreitas and/or @gerdadesign take on this case. 🤔

[alexfauquette]

To test it: https://next.mui.com/x/react-date-pickers/date-time-picker/

My option was
3. Remove the Tab

Maybe it's because I'm used to the previous behavior, but when pressing a Tab, I expect the associated view to switch to another one, and at the same place.

[flaviendelangle]

To remove the tabs, we just have to move the definition of the Tabs slot from NextDateTimePicker/shared.tsx to MobileNextDateTimePicker.tsx and StaticNextDateTimePicker.tsx.

I would prefer 3. over 2. (which will take time, if we decide to do it).
Between 1. and 3. I would tend toward 3. but no strong opinion.

[gerdadesign]

The tabs should theoretically change the content above it. Right now, clicking the clock is closing the modal and focusing the HH input, which breaks expected behaviour and feel accidental since it closes the modal. The highlight is fairly small compared to the large pop up, so can be easily missed that it's highlighting.
Is it a pain to remove the bottom tab for now, and bring it back when we swap out the clock with a different selector?

[flaviendelangle]

Is it a pain to remove the bottom tab for now, and bring it back when we swap out the clock with a different selector?

It is relatively easy to do

[flaviendelangle]

@LukasTy is this still relevant now that we have the new UI ?

[LukasTy]

@flaviendelangle I'm not sure if it is still an issue that matters.
WDYT @alexfauquette?

From the video/screenshot it seems that we might had a bug previously, where we always showed the tabs on the desktop, but if that was the case - we no longer do that.
I've never seen a complaint from the community about this. Correct me if I'm wrong. 👌
To me it seems, that we could close this issue in it's current form, or we need to discuss what we actually need to do here. 🤔