-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Explain how to manage focus for custom edit components #9406
Comments
The custom edit component needs to focus the input when the |
Hi |
@AnastasiaEvgenia When did it stop working? Do you have an example? |
Hi @romgrk I created an example in the sand box bellow. https://codesandbox.io/s/mui-data-grid-example-5mm4qq?file=/src/gridExample/gridExample.js |
Did you observe a change in behavior recently? If so, for which version? |
We recently upgraded to version 6.9.0. You can replicate the problem by uncommenting the columns email and/ or mobile phone, in this sandbox. We also started having this error, that I am trying to replicate in a sand box to create an issue too. |
@AnastasiaEvgenia Yes. We need to update the docs to include this step. I fixed your CodeSandbox: https://codesandbox.io/s/mui-editable-data-grid-tab-stops-after-custom-text-input-forked-3ng8qd?file=/src/components/customEditComponent/customEditInputComponent.js
Could you upgrade to 6.9.1? We just released a version with a fix for this bug. |
Hi @m4theushw. After the version upgrade the maximum call stack size error stopped occurring. |
|
Duplicates
Latest version
Steps to reproduce 🕹
Stack Overflow:
https://stackoverflow.com/questions/75929528/using-mui-datagrid-tab-navigation-across-cells-does-not-work-with-rendercell
SandBox:
https://codesandbox.io/s/cell-tab-navigation-not-working-x996v7?file=/src/App.tsx
In the sandbox, click the pencil to edit the row, then try to tab from Custom 1 to Custom 2.
Also after tabbing away from Custom 2, try to shift+tab back to Custom 1.
You will find tabbing to change focus in these scenarios does not work as expected.
Current behavior 😯
Using tab to change focus to the next element when that element uses a renderEditCell does not work.
Expected behavior 🤔
Using tab to change focus to the next element should focus the next element regardless if a renderEditCell has been used or not.
Context 🔦
This is invaluable when creating new rows, as tabbing between columns is the quickest way to fill out all the data required for a new row.
Your environment 🌎
Tested in Chrome
Order ID or Support key 💳 (optional)
No response
The text was updated successfully, but these errors were encountered: