Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Throws "Maximum call stack size exceeded" #9510

Closed
2 tasks done
mgprieto-soincon opened this issue Jun 28, 2023 · 4 comments · Fixed by #9516
Closed
2 tasks done

[DataGrid] Throws "Maximum call stack size exceeded" #9510

mgprieto-soincon opened this issue Jun 28, 2023 · 4 comments · Fixed by #9516
Assignees
@cherniavskii
Labels
component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user regression A bug, but worse

Comments

@mgprieto-soincon
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:

Steps:

  1. Use the codesandbox example at "Editing" (https://mui.com/x/react-data-grid/editing/)
  2. Change the cols with to "flex".
  3. Change the grid height to "1". (Final codesandbox example: https://codesandbox.io/s/busy-khayyam-ptsh5w?file=/demo.tsx)
  4. Open it in a screen with resolution "1536px x 713.60px"

Current behavior 😯

Get "Maximum call stack size exceeded" error:

Maximum call stack size exceeded
at _extends (https://ptsh5w.csb.app/node_modules/
babel/runtime/helpers/esm/extends.js:17:19
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/gridColumnsUtils.js:92:44
at hydrateColumnsWidth (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/gridColumnsUtils.js:91:26
at Object.handleGridSizeChange [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:231:75
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:59:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at Object.eval [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/dimensions/useGridDimensions.js:115:22
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:53:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:53:20
at Object.handleGridSizeChange [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:231:7
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:59:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at Object.eval [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/dimensions/useGridDimensions.js:115:22
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:53:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:53:20
at Object.handleGridSizeChange [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:231:7
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:59:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at Object.eval [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/dimensions/useGridDimensions.js:115:22
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:53:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:53:20
at Object.handleGridSizeChange [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:231:7
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:59:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at Object.eval [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/dimensions/useGridDimensions.js:115:22
at EventManager.enhancedHandler (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiEventHandler.js:67:98
at EventManager.emit (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/utils/EventManager.js:53:18
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/core/useGridApiInitialization.js:74:40
at Proxy.publishEvent (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/utils/useGridApiMethod.js:21:20
at eval (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:53:20
at Object.handleGridSizeChange [as current] (https://ptsh5w.csb.app/node_modules/
mui/x-data-grid/hooks/features/columns/useGridColumns.js:231:7

Expected behavior 🤔

No to get error

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo 
   System:
    OS: Windows 10 10.0.22621
  Binaries:
    Node: 14.18.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.11 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.12.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Chrome: Not Found
    Edge: Spartan (44.22621.1848.0), Chromium (114.0.1823.58)
  npmPackages:
    @emotion/react: ^11.10.4 => 11.10.4 
    @emotion/styled: ^11.10.4 => 11.10.4 
    @mui/base:  5.0.0-beta.4 
    @mui/core-downloads-tracker:  5.13.4 
    @mui/icons-material: ^5.11.16 => 5.11.16 
    @mui/lab: ^5.0.0-alpha.134 => 5.0.0-alpha.134 
    @mui/material: ^5.13.5 => 5.13.5 
    @mui/private-theming:  5.13.1 
    @mui/styled-engine:  5.13.2 
    @mui/styled-engine-sc: ^5.12.0 => 5.12.0 
    @mui/styles: ^5.13.1 => 5.13.1 
    @mui/system:  5.13.5 
    @mui/types:  7.2.4 
    @mui/utils:  5.13.1 
    @mui/x-data-grid:  6.9.0 
    @mui/x-data-grid-pro: ^6.9.0 => 6.9.0 
    @mui/x-date-pickers:  6.9.0 
    @mui/x-date-pickers-pro: ^6.9.0 => 6.9.0 
    @mui/x-license-pro: ^6.0.4 => 6.0.4 
    @types/react: 17.0.30 => 17.0.30 
    react: 17.0.2 => 17.0.2 
    react-dom: 17.0.2 => 17.0.2 
    styled-components: ^5.3.5 => 5.3.5 
    typescript: ~4.3.5 => 4.3.5

Order ID or Support key 💳 (optional)

#66837
@mgprieto-soincon mgprieto-soincon added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 28, 2023
@zannager zannager added component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user labels Jun 28, 2023
@cherniavskii
Copy link
Member

Hey @mgprieto-soincon
I cannot reproduce the issue with the provided sandbox:

Could you provide a different reproduction example?

@cherniavskii cherniavskii added status: waiting for maintainer These issues haven't been looked at yet by a maintainer status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jun 28, 2023
@mgprieto-soincon
Copy link
Author

mgprieto-soincon commented Jun 28, 2023 •
edited
Loading

We have tried to reproduce you again: https://codesandbox.io/s/busy-khayyam-ptsh5w?file=/demo.tsx&resolutionWidth=1536&resolutionHeight=634

You can see two example with same resolution but diferent screens (the aux screen (bigger) and the laptop).

  • This first one is the aux screen
    image

  • This second is the laptop screen
    image

You can also see that the factor at aux screen is 0.48, when at laptops is 0.36. I dont know if this has anything to do with the bug and the screen resolution, but I hope this will help you.

@github-actions github-actions bot removed the status: waiting for author Issue with insufficient information label Jun 28, 2023
@cherniavskii
Copy link
Member

Thanks @mgprieto-soincon
I managed to create this minimal reproduction example: https://codesandbox.io/s/crimson-bash-7m8g6c?file=/demo.tsx:0-618

@cherniavskii cherniavskii added the bug 🐛 Something doesn't work label Jun 28, 2023
@cherniavskii cherniavskii self-assigned this Jun 28, 2023
This was referenced Jun 28, 2023
Merged
Closed
@cherniavskii cherniavskii added regression A bug, but worse and removed bug 🐛 Something doesn't work labels Jun 30, 2023
This was referenced Jun 30, 2023
Closed
Closed
@cherniavskii
Copy link
Member

This issue should be fixed in https://github.com/mui/mui-x/releases/tag/v6.9.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherniavskii cherniavskii

Labels
component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Fix Maximum call stack size exceeded error when using fractional width cherniavskii/mui-x
3 participants
@cherniavskii @mgprieto-soincon @zannager