Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove routing pages to "id", use page name #1905

Open
2 tasks done
Janpot opened this issue Apr 17, 2023 · 4 comments
Open
2 tasks done

Remove routing pages to "id", use page name #1905

Janpot opened this issue Apr 17, 2023 · 4 comments
Labels
new feature New feature or request scope: toolpad-studio Abbreviated to "studio"

Comments

@Janpot
Copy link
Member

Janpot commented Apr 17, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Use the page name as the url sement instead of the id. i.e. if a page is name "page1" you can navigate to it with the route "/pages/page1".

To stay backwards compatible and not break existing urls of the embeds in notion, we'll keep the optional id property in the page.yml, and automatically add a redirect from /pages/<pageId> to /pages/page1

We should probably fail the build step if two pages have the same id

Examples 🌈

No response

Motivation 🔦

No response

@Janpot Janpot added the new feature New feature or request label Apr 17, 2023
@prakhargupta1
Copy link
Member

prakhargupta1 commented Apr 18, 2023

This will fix: #2324
Also, a bit related to: #388 and #1824

@Kirera-Wainaina
Copy link
Contributor

Kirera-Wainaina commented Aug 13, 2023

@Janpot Hello, I'd like to see if I can manage tackling this issue if that's okay.

@Janpot
Copy link
Member Author

Janpot commented Aug 22, 2023

I believe the preview, production and the editor should follow the same routing semantics. The preview/production is easy to switch to routes that are based on page names. The editor is less straightforward to do that with. As this is not a high priority issue, don't expect this to get reviewed and merged very soon should you still want to take this on.

@Kirera-Wainaina
Copy link
Contributor

Thanks for the clarification

@prakhargupta1 prakhargupta1 added the scope: toolpad-studio Abbreviated to "studio" label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request scope: toolpad-studio Abbreviated to "studio"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants