Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Links are missing a trailing slash in server rendered pages #3401

Closed
oliviertassinari opened this issue Apr 14, 2024 · 3 comments · Fixed by #3402
Closed

[docs] Links are missing a trailing slash in server rendered pages #3401

oliviertassinari opened this issue Apr 14, 2024 · 3 comments · Fixed by #3402
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse scope: toolpad-core Abbreviated to "core"

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Apr 14, 2024

Steps to reproduce

#3301 (comment)

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work regression A bug, but worse docs Improvements or additions to the documentation labels Apr 14, 2024
@Janpot Janpot changed the title [docs] Leading slashes everywhere regression [docs] Links are missing a trailing slash in server rendered pages Apr 15, 2024
@Janpot
Copy link
Member

Janpot commented Apr 15, 2024

I know we've discussed it before, but I can you remind me again why we use trailingSlash?

For my future self I'd like to add a documentation comment about it in the configuration. Having worked a lot on this in the next.js codebase, it feels a bit to me like a neglected feature and I'd expect it to regress regularly. Personally I can't think of a technical limitation that mandates this.

@oliviertassinari
Copy link
Member Author

I can you remind me again why we use trailingSlash?

It's a historical decision. Changing this would mean we need redirect all the URLs. We could use the move of all the docs to subdomains as an opportunity to change it (batching).

@oliviertassinari
Copy link
Member Author

Ok, origin found: mui/material-ui#16705. We started to use trailingSlash precisely to avoid introducing changes to the URLs.

Points added to https://www.notion.so/mui-org/docs-infra-Change-docs-domain-0ce329e7ebc34aba8fbf4f3c5e13eb5d?pvs=4#275627e520784cf4b77733f7805465d9 so we don't forget about this.

@oliviertassinari oliviertassinari added the scope: toolpad-core Abbreviated to "core" label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation regression A bug, but worse scope: toolpad-core Abbreviated to "core"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants