Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React should not be a dependency #4604

Closed
Janpot opened this issue Jan 15, 2025 · 2 comments · Fixed by #4605
Closed

React should not be a dependency #4604

Janpot opened this issue Jan 15, 2025 · 2 comments · Fixed by #4605
Assignees
@bharatkashyap
Labels
bug 🐛 Something doesn't work priority: important This change can make a difference regression A bug, but worse

Comments

@Janpot
Copy link
Member

Janpot commented Jan 15, 2025

Discussed in #4603

Originally posted by JuR-0 January 15, 2025
Hello,
I encountered an error while trying to use toolpad.
Toolpad/utils has react 19.0 as a dependency. I'm quite new to react but I had understood that react should never be a dependency but added as a peerDependency. Is it an bug or did I misunderstood something?

It results in 2 version of react being installed.
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 15, 2025
@Janpot Janpot added bug 🐛 Something doesn't work priority: important This change can make a difference regression A bug, but worse labels Jan 15, 2025
@Janpot
Copy link
Member Author

Janpot commented Jan 15, 2025

correct, looks like this recently made it in. we'll fix it.

@bharatkashyap bharatkashyap mentioned this issue Jan 16, 2025
Merged
@bharatkashyap bharatkashyap changed the title React should be a dependency React should not be a dependency Jan 16, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Completed in MUI Toolpad public roadmap Jan 16, 2025
@github-actions GitHub Actions
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@github-actions github-actions bot removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bharatkashyap bharatkashyap

Labels
bug 🐛 Something doesn't work priority: important This change can make a difference regression A bug, but worse
Projects
MUI Toolpad public roadmap
Status: Completed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[utils] Remove React dependency bharatkashyap/mui-toolpad
2 participants
@Janpot @bharatkashyap