Fix Next.js Pages Router pathname in AppProvider #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
commented
Feb 4, 2025
| @@ -8,7 +8,7 @@ import type { AppProviderProps, Navigate, Router } from '../AppProvider'; | |||
| * @ignore - internal component. | |||
| */ | |||
| export function NextAppProviderPages(props: AppProviderProps) { | |||
| const { push, replace, asPath, query } = useRouter(); | |||
| const { push, replace, pathname, query } = useRouter(); | |||
There was a problem hiding this comment.
@Janpot is this ok or is there a reason why you were using asPath?
There was a problem hiding this comment.
is there a reason why you were using
asPath?
only short-sightedness 🙂
Netlify deploy preview |
Janpot
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
pathnamein Next.js Pages Router adapter.Closes #4645 (comment)