Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate code generation via CI #47

Closed
masih opened this issue Jul 12, 2021 · 4 comments · Fixed by #72
Closed

Automate code generation via CI #47

masih opened this issue Jul 12, 2021 · 4 comments · Fixed by #72
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked team/ipdx Notify IP Developer Experience team

Comments

@masih
Copy link
Member

masih commented Jul 12, 2021

Would it make sense to automate the code generated here by setting up a CI job that either runs periodically or watches the changes to the multicodec CSV file?
@masih masih mentioned this issue Jul 12, 2021
Merged
@mvdan
Copy link
Contributor

mvdan commented Jul 14, 2021

I'd personally say "no", see #49 (comment)

@aschmahmann aschmahmann added effort/days Estimated to take multiple days, but less than a week exp/novice Someone with a little familiarity can pick up P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked labels Jul 23, 2021
@lidel
Copy link
Member

lidel commented Oct 14, 2022 •
edited
Loading

I think there is existential risk of not updating library to follow changes to table.csv:

We really can't afford running in blind here.

Desired state

See prior art in ipfs/ipfs-webui#2049 – we have a CI that runs once a week and if there are any changes, opens a PR + pings GUI team for review.

We want the same thing for this library:

  1. Run once a week and see if git submodule init && git submodule update --remote && go generate produced any changes
  2. IF there are changes, commit them to sync-table-csv branch, and open a PR against master (if PR already exists, force-push latest version)

@lidel lidel added P1 High: Likely tackled by core team if no one steps up team/ipdx Notify IP Developer Experience team effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo and removed P2 Medium: Good to have, but can wait until someone steps up exp/novice Someone with a little familiarity can pick up effort/days Estimated to take multiple days, but less than a week labels Oct 14, 2022
@lidel
Copy link
Member

lidel commented Oct 14, 2022 •
edited
Loading

@galargh would you or someone from IPDX be able to add this to your queue? 🙏

@galargh galargh mentioned this issue Oct 17, 2022
Merged
@galargh
Copy link
Contributor

galargh commented Oct 17, 2022

@galargh would you or someone from IPDX be able to add this to your queue? 🙏

Sure, there you go - #72

@lidel lidel closed this as completed in #72 Oct 17, 2022
@BigLep BigLep moved this to 🎉 Done in IPFS Shipyard Team Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours kind/maintenance Work required to avoid breaking changes or harm to project's status quo P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked team/ipdx Notify IP Developer Experience team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: create Go Generate workflow galargh/go-multicodec
5 participants
@lidel @masih @aschmahmann @mvdan @galargh