JPG images are broken on Windows x64 nigthtly build

[promi]

OS is Windows 10 x64, Build https://dev.azure.com/Mumble-VoIP/Mumble/_build/results?buildId=2267&view=results

Git commit is d2d5dc2

JPG images are not shown, PNG images work fine.

[Krzmbrzl]

What server version are you using? Is this behavior consistent across servers?
How do you send the images? I just tried it on Linux using the latest master version with a server hosted locally. When Drag&Dropping a JPG image to the chatbar and sending it that way, it is displayed on a second client running on the same machine just fine (it is also displayed properly in the sending client).

Is the JPG not shown on the receiving or the sending end? Or both?

Have you tried using different JPGs?

[hjf288]

Same on Windows 10 x64 - Using the image picker to insert an image on a channel using a JPG results in "Image format not recognized", manually inserting a using base64 no longer works and jpg images set in existing channel descriptions are no longer displayed.

Non nightly client works fine.

[davidebeatrici]

We probably have to explicitly import and link to the plugin, like we do for the SVG one:

mumble/src/mumble/CMakeLists.txt

Lines 336 to 349 in 06d0dbb

	if(static)
	if(TARGET Qt5::QSQLiteDriverPlugin)
	include_qt_plugin(mumble PRIVATE "QSQLiteDriverPlugin")
	target_link_libraries(mumble PRIVATE Qt5::QSQLiteDriverPlugin)
	endif()
	if(TARGET Qt5::QSvgIconPlugin)
	include_qt_plugin(mumble PRIVATE "QSvgIconPlugin")
	target_link_libraries(mumble PRIVATE Qt5::QSvgIconPlugin)
	endif()
	if(TARGET Qt5::QSvgPlugin)
	include_qt_plugin(mumble PRIVATE "QSvgPlugin")
	target_link_libraries(mumble PRIVATE Qt5::QSvgPlugin)
	endif()
	endif()

However, according to microsoft/vcpkg#11727 (comment), with Qt 5.15 that is not required anymore.

The 64 bit build doesn't use the latest environment due to me forgetting to switch to it:

mumble/.ci/azure-pipelines/main.yml

Lines 8 to 31 in 06d0dbb

	- job: Windows_x86_64
	displayName: Windows (x86_64)
	pool:
	vmImage: 'windows-latest'
	variables:
	MUMBLE_ENVIRONMENT_VERSION: 'win64-static-1.4.x-2020-05-27-ecb3c64-1151'
	MUMBLE_ENVIRONMENT_TRIPLET: 'x64-windows-static-md'
	VCVARS_PATH: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvars64.bat'
	steps:
	- template: steps_windows.yml
	parameters:
	arch: 'x64'
	- job: Windows_x86
	displayName: Windows (x86)
	pool:
	vmImage: 'windows-latest'
	variables:
	MUMBLE_ENVIRONMENT_VERSION: 'win32-static-1.4.x-2020-07-22-dbd6271-1162'
	MUMBLE_ENVIRONMENT_TRIPLET: 'x86-windows-static-md'
	VCVARS_PATH: 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsamd64_x86.bat'
	steps:
	- template: steps_windows.yml
	parameters:
	arch: 'x86'

I'm going to create a pull request right now.

[davidebeatrici]

Could you test the build produced in #4404, please?

[hjf288]

Could you test the build produced in #4404, please?

@davidebeatrici Resolves the issue - JPGs are now visible and able to be used.

One slightly off topic note - it would be helpful if the Snapshot MSI builds are able to upgrade the installed version, it's a bit frustrating to have to remove the old version via Add/Remove programs in order to upgrade the snapshot.

[davidebeatrici]

@davidebeatrici Resolves the issue - JPGs are now visible and able to be used.

Thank you very much for testing it!

One slightly off topic note - it would be helpful if the Snapshot MSI builds are able to upgrade the installed version, it's a bit frustrating to have to remove the old version via Add/Remove programs in order to upgrade the snapshot.

#4407