Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding video JSON to the Next 15 build + Turbopack warning #316

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

luwes
Copy link
Collaborator

@luwes luwes commented Nov 1, 2024

fix #315

@luwes luwes self-assigned this Nov 1, 2024
Copy link

height bot commented Nov 1, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

vercel bot commented Nov 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-video-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2024 6:56pm

@luwes luwes changed the title fix: adding video JSON to the build + Turbopack warning fix: adding video JSON to the Next 15 build + Turbopack warning Nov 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 88.40580% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.88%. Comparing base (728406a) to head (42cd96f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/with-next-video.ts 77.77% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   89.19%   88.88%   -0.31%     
==========================================
  Files          32       32              
  Lines        2554     2601      +47     
  Branches      343      362      +19     
==========================================
+ Hits         2278     2312      +34     
- Misses        275      286      +11     
- Partials        1        3       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luwes luwes merged commit 199e158 into muxinc:main Nov 1, 2024
8 checks passed
@luwes luwes deleted the next15-fixes branch November 1, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants