Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inline-Tables #6

Closed
d3xter opened this issue Feb 7, 2015 · 8 comments
Closed

Support Inline-Tables #6

d3xter opened this issue Feb 7, 2015 · 8 comments
Assignees

Comments

@d3xter
Copy link
Contributor

d3xter commented Feb 7, 2015

Toml 0.3.1 spec supports Inline-Tables:

[logger]
   sink = "FileSink"
   parameters = { file = "/home/user/file.log", logLevel = "Warning", fileSize = 32 }
@mwanji
Copy link
Owner

mwanji commented Feb 7, 2015

No, it doesn't. However, it seems fairly certain that the next version will: toml-lang/toml#235 was merged only a few hours ago.

@mwanji mwanji self-assigned this Feb 8, 2015
@mwanji
Copy link
Owner

mwanji commented Feb 8, 2015

In case you need this quickly, I'll be implementing this on the wip branch. Test cases, in particular, are very welcome!

@mwanji
Copy link
Owner

mwanji commented Feb 11, 2015

This is now on on the wip branch. Please have a look to see if it works for you, @d3xter.

@d3xter
Copy link
Contributor Author

d3xter commented Feb 14, 2015

It works as expected, thanks.
Should I add more test-cases?

@mwanji
Copy link
Owner

mwanji commented Feb 14, 2015

If you come up with some I haven't covered, please do! I'm working on fixing this uncommitted one:

a = {}
[a]

which should fail, but doesn't.

@d3xter
Copy link
Contributor Author

d3xter commented Feb 14, 2015

Alright, will have a look during the weekend into the test code and see if something is missing

@mwanji
Copy link
Owner

mwanji commented Feb 14, 2015

Thanks, much appreciated!

@mwanji
Copy link
Owner

mwanji commented Apr 13, 2015

This was released in v0.4.0

@mwanji mwanji closed this as completed Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants