Also allow subclasses of TextFileContentsManager #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only load the jupytext.TextFileContentsManager as contents manager if the configured class is not already an instance of it.
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
=======================================
Coverage 99.23% 99.23%
=======================================
Files 65 65
Lines 6142 6142
=======================================
Hits 6095 6095
Misses 47 47
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 08b8951 into 939d437 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
The alert is not caused by these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only load the jupytext.TextFileContentsManager as contents manager
if the configured class is not already an instance of it.
We use a subclass of TextFileContentsManager to extend the rename and delete methods. However, our subclass is replaced by the provided TextFileContentsManager since it is not exactly that class.
This allows custom classes if they are a subclass of TextFileContentsManager.