Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parsing of myst notebooks to new (markdown-it based) parser #473

Merged
merged 9 commits into from
Apr 3, 2020

Conversation

chrisjsewell
Copy link
Contributor

@chrisjsewell chrisjsewell commented Mar 29, 2020

Hey @mwouts, first just to clarify this should not be merged just yet. It is an update to use the (currently) pre-release executablebooks/MyST-Parser#123, which utilises markdown-it-py, my shiny new markdown parser 😁

As you can see, it does not affect any of the tests, and thus shouldn't be noticeable on the front-end.

@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #473 into master will decrease coverage by 0.03%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   98.86%   98.82%   -0.04%     
==========================================
  Files          80       80              
  Lines        7899     7998      +99     
==========================================
+ Hits         7809     7904      +95     
- Misses         90       94       +4     
Impacted Files Coverage Δ
jupytext/myst.py 97.32% <96.03%> (-1.01%) ⬇️
jupytext/formats.py 97.48% <100.00%> (ø)
tests/test_ipynb_to_myst.py 100.00% <100.00%> (ø)
tests/test_combine.py 97.26% <0.00%> (-2.74%) ⬇️
jupytext/combine.py 100.00% <0.00%> (ø)
tests/test_stringparser.py 100.00% <0.00%> (ø)
jupytext/stringparser.py 95.65% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2b3bfb...a848520. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2020

This pull request fixes 1 alert when merging 8a8fb3d into c2b3bfb - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@mwouts
Copy link
Owner

mwouts commented Mar 31, 2020

Sounds great! Just let me know when you want this to be merged.

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request fixes 1 alert when merging 67e1214 into 35552c4 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request fixes 1 alert when merging eed36e3 into 35552c4 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@chrisjsewell chrisjsewell marked this pull request as ready for review April 1, 2020 16:11
@lgtm-com
Copy link

lgtm-com bot commented Apr 1, 2020

This pull request fixes 1 alert when merging a848520 into 35552c4 - view on LGTM.com

fixed alerts:

  • 1 for Module is imported with 'import' and 'import from'

@chrisjsewell
Copy link
Contributor Author

@mwouts this is ready for review/merge thanks 😄

@mwouts
Copy link
Owner

mwouts commented Apr 3, 2020

Thank you @chrisjsewell , I will take this for the next release, which I hope to finalize next week.

By the way, I occasionally run pylint on the code, you don't mind if I add a few docstrings, etc to myst.py ? I'll open a separate PR for this.

@mwouts mwouts added this to the 1.4.2 milestone Apr 3, 2020
@chrisjsewell
Copy link
Contributor Author

Yeh that’s no problem at all 👍

@mwouts mwouts merged commit 59249be into mwouts:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants