-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update parsing of myst notebooks to new (markdown-it based) parser #473
Conversation
Codecov Report
@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 98.86% 98.82% -0.04%
==========================================
Files 80 80
Lines 7899 7998 +99
==========================================
+ Hits 7809 7904 +95
- Misses 90 94 +4
Continue to review full report at Codecov.
|
This pull request fixes 1 alert when merging 8a8fb3d into c2b3bfb - view on LGTM.com fixed alerts:
|
Sounds great! Just let me know when you want this to be merged. |
This reverts commit 90e3898.
This pull request fixes 1 alert when merging 67e1214 into 35552c4 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging eed36e3 into 35552c4 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging a848520 into 35552c4 - view on LGTM.com fixed alerts:
|
@mwouts this is ready for review/merge thanks 😄 |
Thank you @chrisjsewell , I will take this for the next release, which I hope to finalize next week. By the way, I occasionally run |
Yeh that’s no problem at all 👍 |
Hey @mwouts, first just to clarify this should not be merged just yet. It is an update to use the (currently) pre-release executablebooks/MyST-Parser#123, which utilises markdown-it-py, my shiny new markdown parser 😁
As you can see, it does not affect any of the tests, and thus shouldn't be noticeable on the front-end.