-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to let pypi know that Jupytext 1.7.1 is the last version with explicit support of Python 2.7 and 3.5 #697
Comments
Heya, I note that you do not have in your setup.py |
Hi @chrisjsewell , yes I agree, but I think that before that, we need to package a version that will work again with Python < 3.6, otherwise I am afraid that pypi will still try to install Jupytext 1.8.0 when called from Python 2.7 or 3.5. I'll try to do this with cbd0400. Then I'll add |
|
The first half of the plan worked... the CI for my other project is green now 😄 |
And the second half worked as well 😌 ! In that run the Python 3.5 test suite was using Jupytext 1.8.1, while the Python 3.7 suite was using Jupytext 1.8.2. |
Looks good to me 😀 |
One of my project that uses Jupytext on the CI is now failing on Python 2.7 and 3.5, with this message:
Between Jupytext 1.7.1 and 1.8.0 we removed the explicit support for Python 2.7 and 3.5 (but they should still work), and we replaced the conditional dependency on markdown-it-py when Python>=3.6 with a full dependency.
Still I would like to find a plan to make the
itables
CI work again on Python 2.7 and 3.5. Maybe we could just provide enough information to pypi to let it download the appropriate version of Jupytext?@chrisjsewell , do you know how to do that? Maybe an option would be to make the dependency on markdown-it-py~=0.6.0 conditional on
python_version >= '3.6'
again in a new release of Jupytext 1.8.1? And then in Jupytext 1.8.2 we could remove the condition and take a dependency on Python>=3.6?The text was updated successfully, but these errors were encountered: