⬆️ UPDATE: markdown-it-py to v1

[chrisjsewell]

Shouldn't actually change anything specific for jupytext, see: https://github.com/executablebooks/markdown-it-py/blob/master/CHANGELOG.md

[mwouts]

Hi @chrisjsewell 👋 , thanks for the update, I'll be happy to take this in the next release! I was planning to work on version 1.11.2 soon (or maybe 1.12.0, since there will be quite a few (small) updates)

Shouldn't actually change anything specific for jupytext

Just to double check, you mean we don't need to increase the version number for the MyST format? (jupytext.myst.myst_version has been at 0.13 for a while, maybe we should replace that fixed number with some import from markdown-it-py?)

[chrisjsewell]

Heya 👋, cheers

Just to double check, you mean we don't need to increase the version number for the MyST format?

Well this should not affect at all how MyST Notebooks are converted to Jupyter Notebooks, so in that respect I'd say no.
Can you remind me what effect changing the version has (how it will affect existing MyST Notebooks)?

FYI, I've got a sneaky package to fix my short term circular-dependency issues for myst development https://pypi.org/project/jupytext-ebp/ 😉

[mwouts]

Can you remind me what effect changing the version has

No other effect as changing the format_version field in the YAML header. This can be useful for compatibility if you want to parse past versions in a different manner.

FYI, I've got a sneaky package to fix my short term circular-dependency issues for myst development https://pypi.org/project/jupytext-ebp/ wink

Oh I guess you would appreciate a faster release? If you need that I'll be happy to ship your change first. What is the circular dependency issue precisely?

[chrisjsewell]

This can be useful for compatibility if you want to parse past versions in a different manner.

So if we do change the version here, notebooks with older versions will still work fine? Thats the thing I just wanted to check.

What is the circular dependency issue precisely?

Oh its mainly just for development: markdown-it-py's documentation is created with myst-nb, which has the dependency chain: markdown-it-py -> myst-parser -> myst-nb, and then myst-nb also has a test dependency on jupytext, see: executablebooks/MyST-NB#320
Mainly I just wanted to have everything ready and checked before making the non-beta markdown-it-py v1 release

[mwouts]

Hi @chrisjsewell , sorry for the delay, I'll try to get the new version done by the end of the week-end :)
Right now I am trying to add a few changes on top of yours in the environment files at #773

So if we do change the version here, notebooks with older versions will still work fine?

Well the format version can be useful at the time of converting the text notebook to ipynb, like we do here:

jupytext/jupytext/cell_reader.py

Lines 232 to 240 in be5f4aa

	# Markdown files in version >= 1.3 represent code chunks with no language as Markdown cells
	if self.format_version not in ["1.0", "1.1"]:
	self.cell_type = "markdown"
	self.explicit_eoc = False
	cell_end_marker += 1
	self.content = lines[:cell_end_marker]
	# Previous versions mapped those to raw cells
	else:
	self.cell_type = "raw"

However any document will be saved in the current version, so if you decide to upgrade the version to 0.14 then every myst:md document created with the new version of Jupytext will have a format_version equal to 0.14.

[mwouts]

Merged at #773