Improve CLI message #905
Closed
Improve CLI message #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --to is not a notebook, but the target already exists, then the suggested "use --update" is confusing as it's not valid.
|
Hi @st-- , yes sure that's a great idea! I'll apply the pre-commit hooks on your contribution and take it within a few days. Thanks |
Merged
|
I am not sure I can push to a branch that you own, so I have created another one at #911 . Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --to is not a notebook, but the target already exists, then the suggested "use --update" is confusing as it's not valid. This PR only suggest --update when the target is actually an .ipynb file and it would be a valid action.