Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Template Parameter for getFormattedChat #84

Closed
a-ghorbani opened this issue Nov 8, 2024 · 1 comment
Closed

Expose Template Parameter for getFormattedChat #84

a-ghorbani opened this issue Nov 8, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@a-ghorbani
Copy link
Contributor

By exposing this parameter, we can enable users to customize and pass their templates, not just the ones that come with gguf.

@jhen0409 jhen0409 added the enhancement New feature or request label Nov 10, 2024
@jhen0409
Copy link
Member

This is easy to expose and it will be added soon, but I'll recommend user to use jinja parser for make prompt from template, currently the chat template in llama.cpp is a bit limited:

https://github.com/ggerganov/llama.cpp/blob/f245cc28d4eb900efad0bc740145f58d713c6e4f/src/llama.cpp#L21637-L21639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants