Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kong 0.10 API format changes #63

Closed
cknowles opened this issue Mar 5, 2017 · 6 comments
Closed

Kong 0.10 API format changes #63

cknowles opened this issue Mar 5, 2017 · 6 comments

Comments

@cknowles
Copy link

cknowles commented Mar 5, 2017

I thought worth creating a placeholder for the Kong 0.10 API format changes. Release notes are on https://github.com/Mashape/kong/releases but there are also a few changes to the API not explicitly listed.

So far I found the apis endpoint changes:

  1. request_host -> hosts
  2. request_path -> uris
  3. strip_request_path -> strip_uri
  4. Adds retries, upstream_connect_timeout, upstream_read_timeout and upstream_send_timeout

0.9.9

✗ curl -s http://localhost:8001/apis | jq
{
  "data": [
    {
      "created_at": 1488523764000,
      "id": "38a544a4-e190-46dc-86b5-09d9c54ab7b0",
      "name": "mockbin",
      "preserve_host": false,
      "request_host": "mockbin.com"
      "request_path": "/mockbin",
      "strip_request_path": true,
      "upstream_url": "http://mockbin.com/",
    }
  ],
  "total": 1
}

0.10 RC4

✗ curl -s http://localhost:8001/apis | jq
{
  "data": [
    {
      "created_at": 1488523764000,
      "hosts": [
        "mockbin.com"
      ],
      "id": "38a544a4-e190-46dc-86b5-09d9c54ab7b0",
      "name": "mockbin",
      "preserve_host": false,
      "retries": 5,
      "strip_uri": true,
      "upstream_connect_timeout": 60000,
      "upstream_read_timeout": 60000,
      "upstream_send_timeout": 60000,
      "upstream_url": "http://mockbin.com",
      "uris": [
        "/mockbin"
      ]
    }
  ],
  "total": 1
}
@CyExy
Copy link
Contributor

CyExy commented Mar 15, 2017

Is the API schema change going to be a PC break?

@CyExy
Copy link
Contributor

CyExy commented Mar 15, 2017

Hmm.., the release doc actually says that it is not going to support the old format. So not sure can we maintain backwards compatibility or not.

@cknowles
Copy link
Author

From the looks of things yes there's little in the way of compatibility. There could be some ways to maintain some basic compatibility in kongfig. For example if uris is one in length pass it through on the old format if we can detect the version. However, I think users can easily upgrade if instructions are provided. e.g. 1) upgrade kong, 2) take an export with a newer kongfig version.

@Tombar
Copy link

Tombar commented Apr 10, 2017

Hello, any news about adding support for KONG v0.10?

@rogoman
Copy link
Contributor

rogoman commented Apr 11, 2017

A proposed fix for this: #64

@CyExy
Copy link
Contributor

CyExy commented Apr 12, 2017

I think we need to support applying pre 10 kongfig files to kong 10. #64 deals with the dumping so I'll try to fix the apply side.

@CyExy CyExy closed this as completed in 3aaa289 Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants