Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain the label for link but hide the label instead #38

Open
dracos opened this issue Feb 9, 2023 · 2 comments
Open

Maintain the label for link but hide the label instead #38

dracos opened this issue Feb 9, 2023 · 2 comments
Assignees

Comments

@dracos
Copy link
Member

dracos commented Feb 9, 2023

#30 removed the for from the label. A further accessibility audit with a user who disabled all CSS but had JS enabled raised the issue that we then had an input with no matching label... I think the solution that fixes this but maintains the previous thing being solved also is therefore to revert #30, and instead create a copy of the label, and hide the label with the for. So it matches the item's behaviour.

@zarino
Copy link
Member

zarino commented Feb 15, 2023

Sounds sensible to me!

We’ll also want to make sure that the current click handler we have assigned to the real label (to toggle the menu) is added to the "fake" label instead.

@dracos
Copy link
Member Author

dracos commented Jul 24, 2024

To note our current behaviour: https://github.com/mysociety/fixmystreet/blob/9c9053065fd7692cc904bf4130fa51e1fd37aafd/web/cobrands/fixmystreet/fixmystreet.js#L1110 - we do as above, put the for back in and hide the label, and add a span

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants