Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Crystal 0.24.1 #53

Closed
faultyserver opened this issue Nov 20, 2017 · 3 comments
Closed

Upgrade to Crystal 0.24.1 #53

faultyserver opened this issue Nov 20, 2017 · 3 comments
Labels
infrastructure Issues relating to the infrastructure around Myst development. CI, GitHub, Crystal versions, etc.
Milestone

Comments

@faultyserver
Copy link
Member

Crystal 0.24.0 is currently a pre-release, though in actuality the content of the release has been static for a while.

I think it'd be a good idea to get ahead of the curve and upgrade the Crystal version before the next minor release of Myst. There are a few features that I'm really looking forward, but mainly better stacktraces, including locations on macOS and this bugfix for Constant manipulation inside a static method (14a79e0 has more details) :)

As for an upgrade path, I know there are a few TODOs in the codebase that reference Crystal 0.24, so those should be evaluated with this (though they won't necessarily be resolved by it). Also, expect_raises in the specs will now require an exception type to be given. In most cases, these should already be given as ParseError or SyntaxError, but may need to be added.

A successful resolution to this issue will be compiling with --release on Crystal 0.24.0.

@faultyserver faultyserver added the infrastructure Issues relating to the infrastructure around Myst development. CI, GitHub, Crystal versions, etc. label Nov 20, 2017
@faultyserver faultyserver added this to the Next milestone Nov 20, 2017
@faultyserver
Copy link
Member Author

0.24.1 has been tagged for release, so this upgrade should be coming sooner rather than later.

@faultyserver faultyserver changed the title Upgrade to Crystal 0.24.0 Upgrade to Crystal 0.24.1 Dec 23, 2017
@faultyserver
Copy link
Member Author

Crystal 0.24.1 has been properly released and binaries are available. Not sure how long it will take to propagate to brew and apt, but this should finally be a realistic goal :)

@faultyserver
Copy link
Member Author

Brew finally updated and travis is running 0.24.1, so now I can finally start on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues relating to the infrastructure around Myst development. CI, GitHub, Crystal versions, etc.
Projects
None yet
Development

No branches or pull requests

1 participant