Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports for Optional chaining & Nullish coalescing #8

Merged
merged 5 commits into from
Jun 15, 2020

Conversation

ota-meshi
Copy link
Contributor

@ota-meshi ota-meshi commented Jun 14, 2020

  • Updated ReferenceTracker to parse optional chaining.
  • Updated getStaticValue to parse optional chaining and nullish coalescing.
  • Fixed hasSideEffect infinite loop.
    It will continue to traverse the type string on nodes that do not exist in "eslint-visitor-keys", resulting in an infinite loop.

- Updated ReferenceTracker to parse optional chaining.
- Updated getStaticValue to parse optional chaining.
- Fixed hasSideEffect infinite loop.
  It will continue to traverse the `type` string on nodes that do not exist in `"eslint-visitor-keys"`, resulting in an infinite loop.
@ota-meshi ota-meshi changed the title Supports for Optional chaining Supports for Optional chaining & Nullish coalescing Jun 14, 2020
Copy link
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much!

@mysticatea mysticatea merged commit 9b2885a into mysticatea:master Jun 15, 2020
@ota-meshi ota-meshi deleted the optional-chaining branch June 15, 2020 23:20
fisker pushed a commit to fisker/eslint-utils that referenced this pull request Nov 28, 2022
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants